diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..ac91c59 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app's domain-specific name +export { useDebounce as useSearchDebounce } diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..1e73644 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -14,16 +14,17 @@ type Props = { "aria-label"?: string } +/** Last-resort accessible name for an icon-only button with no author-supplied label. */ +const FALLBACK_ICON_ONLY_LABEL = "Button" + /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons render no visible text, so they must expose an accessible + * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). When `iconOnly` + * is set and no label is supplied we fall back to a generic label so the + * control is never left nameless, and warn in development so the caller can + * supply a meaningful one. */ export function Button({ children, @@ -34,13 +35,22 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + const hasAriaLabel = typeof ariaLabel === "string" && ariaLabel.trim() !== "" + const resolvedAriaLabel = iconOnly ? (hasAriaLabel ? ariaLabel : FALLBACK_ICON_ONLY_LABEL) : ariaLabel + + if (process.env.NODE_ENV !== "production" && iconOnly && !hasAriaLabel) { + console.warn( + "Button: `iconOnly` buttons require an `aria-label` to give screen reader " + + `users an accessible name (WCAG 2.2 SC 4.1.2). Falling back to "${FALLBACK_ICON_ONLY_LABEL}".`, + ) + } + return (