Round up document.documentElement.offsetHeight ??

[golfecholima]

In src/frames.js, I wonder if it would make sense to round up to the nearest whole pixel here:

function getDocumentHeight() {
	return document.documentElement.offsetHeight;
}

In LAT CMS at least it appears to be causing scroll bars (presumably because our CMS is rounding down??)

Surely there's some unintended consequence of doing this that I'm not thinking of ...

[rdmurphy]

There’s nothing to round in this case because offsetHeight is already a rounded integer.

Unless something has changed since I left I do remember that the CMS devs chose to not use my code for the parent/host side of frames and rewrote it, so my first guess would be to see if something has changed there.

Alternatively there may be something within the frame’s contents that is not being taken into account when offsetHeight is calculated. This shouldn’t be the problem but I would check and see if there is any unneeded margin/padding being added there at the very top or bottom of the embed.