Skip to content

Should we allow directly accessing vis global object? #70

Description

@qiankunxie

Currently we need to access vis object from global scope, for angular, should we make a service wrapper for vis object?

        .factory('vis', ['$window', function($window) {
            if (!$window.vis) {
                console.log("error loading library");
                return {};
            }
        	return $window.vis;
        }])

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions