From 427958f5323788377c63c7792f8133bb3c8107c3 Mon Sep 17 00:00:00 2001
From: JongKyung Lee <jongkyung0413@gmail.com>
Date: Tue, 10 Nov 2026 09:30:56 +0900
Subject: [PATCH] ci: remove unused download-previous-rolldown-binaries job

The job uploaded an npm-latest Linux rolldown binding that every consumer
replaced immediately: build-upstream always reruns download-rolldown-binaries
and copies the pinned host binding into the same directory. Because the job
was missing from done.needs, a failure in it skipped all E2E and snapshot
jobs while the required done check still passed.

build-cli-test-binaries and cli-e2e-test-musl now gate on detect-changes
directly so docs-only changes still skip them.
---
 .github/workflows/ci.yml | 65 +++-------------------------------------
 1 file changed, 4 insertions(+), 61 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9dc4d62d39..546a895c9c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -135,19 +135,6 @@ jobs:
       - name: Run vp fmt --check
         run: pnpm vp fmt --check
 
-  download-previous-rolldown-binaries:
-    needs: detect-changes
-    if: needs.detect-changes.outputs.code-changed == 'true'
-    runs-on: ubuntu-latest
-    timeout-minutes: 20
-    permissions:
-      contents: read
-      packages: read
-    steps:
-      - uses: taiki-e/checkout-action@7d1e50e93dc4fb3bba58f85018fadf77898aee8b # v1.4.2
-      - uses: ./.github/actions/download-rolldown-binaries
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
   test:
     needs: detect-changes
     if: needs.detect-changes.outputs.code-changed == 'true'
@@ -440,7 +427,6 @@ jobs:
   cli-e2e-test:
     name: CLI E2E test
     needs:
-      - download-previous-rolldown-binaries
       - build-windows-cli
       - build-cli-test-binaries
     strategy:
@@ -467,12 +453,6 @@ jobs:
       - name: Install docs dependencies
         run: pnpm -C docs install --frozen-lockfile
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       # Prebuilt by build-windows-cli (Linux + cargo-xwin); the artifact
       # paths are workspace-relative, so this places the binding into
       # packages/cli/binding/ and the CLI binaries into
@@ -993,8 +973,8 @@ jobs:
   # them across the E2E job and snapshot shards. Tar preserves permissions.
   build-cli-test-binaries:
     name: Build CLI test binaries (${{ matrix.target }})
-    needs:
-      - download-previous-rolldown-binaries
+    needs: detect-changes
+    if: needs.detect-changes.outputs.code-changed == 'true'
     strategy:
       fail-fast: false
       matrix:
@@ -1016,12 +996,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       - name: Build with upstream
         uses: ./.github/actions/build-upstream
         with:
@@ -1124,12 +1098,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       - uses: ./.github/actions/download-cli-test-binaries
         with:
           target: ${{ matrix.target }}
@@ -1213,7 +1181,6 @@ jobs:
   cli-snapshot-test-windows:
     name: CLI snapshot test (Windows, shard ${{ matrix.shard }}/3)
     needs:
-      - download-previous-rolldown-binaries
       - build-windows-cli
       - build-windows-tests
     strategy:
@@ -1261,12 +1228,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       # See the cli-e2e-test job for details on the prebuilt binaries.
       - name: Download prebuilt Windows binaries
         uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
@@ -1400,8 +1361,8 @@ jobs:
 
   cli-e2e-test-musl:
     name: CLI E2E test (Linux x64 musl)
-    needs:
-      - download-previous-rolldown-binaries
+    needs: detect-changes
+    if: needs.detect-changes.outputs.code-changed == 'true'
     runs-on: namespace-profile-linux-x64-default
     timeout-minutes: 20
     steps:
@@ -1415,12 +1376,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       # Cross-compile for musl on the glibc host
       - name: Build with upstream (musl)
         uses: ./.github/actions/build-upstream
@@ -1560,12 +1515,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       - uses: ./.github/actions/download-cli-test-binaries
         with:
           target: x86_64-unknown-linux-gnu
@@ -1672,12 +1621,6 @@ jobs:
 
       - uses: ./.github/actions/setup-ci-node
 
-      - uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
-        with:
-          name: rolldown-binaries
-          path: ./rolldown/packages/rolldown/src
-          merge-multiple: true
-
       - uses: ./.github/actions/download-cli-test-binaries
         with:
           target: ${{ matrix.target }}