Skip to content

Reserve fee notes for batch builders - #2563

Open
Mirko-von-Leipzig wants to merge 3 commits into
nextfrom
mirko/deny-fee-eaters
Open

Mirko-von-Leipzig wants to merge 3 commits into
nextfrom
mirko/deny-fee-eaters

Conversation

@Mirko-von-Leipzig

@Mirko-von-Leipzig Mirko-von-Leipzig commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

The mempool rejects standalone transactions that consume fee notes from uncommitted transactions. This keeps those notes available to the batch builder for fee collection.

Committed, unspent fee notes remain available to consume. User-submitted batches can consume fee notes as their reward for building the batch.

Closes #2558. Part of #2501.

Changelog

[[entry]]
scope       = "node"
impact      = "changed"
description = "Reject standalone transactions that consume fee notes from uncommitted transactions."

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread crates/block-producer/src/mempool/graph/dag.rs
Comment thread crates/block-producer/src/mempool/mod.rs Outdated
Comment thread crates/block-producer/src/mempool/tests/add_transaction.rs
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title Deny fee thieves fix(mempool): reserve uncommitted fee notes for batch builders Sep 16, 2026
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title fix(mempool): reserve uncommitted fee notes for batch builders Reserve uncommitted fee notes for batch builders Sep 16, 2026
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title Reserve uncommitted fee notes for batch builders Reserve fee notes for batch builders Sep 16, 2026

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My previous comments are still unaddressed but they are very optional so feel free to disregard

@kkovaacs kkovaacs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mirko-von-Leipzig
Mirko-von-Leipzig removed this pull request from stack #2569 September 17, 2026 11:59
@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2641 September 17, 2026 12:01

@PhilippGackstatter PhilippGackstatter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread crates/block-producer/src/mempool/mod.rs
@Mirko-von-Leipzig
Mirko-von-Leipzig removed this pull request from stack #2641 September 18, 2026 09:45
@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2649 September 18, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject transactions that consume fee notes

4 participants