Skip to content

Preserve user-submitted batch proofs - #2565

Open
Mirko-von-Leipzig wants to merge 3 commits into
mirko/require-fee-notesfrom
mirko/preserve-user-batch-proofs
Open

Mirko-von-Leipzig wants to merge 3 commits into
mirko/require-fee-notesfrom
mirko/preserve-user-batch-proofs

Conversation

@Mirko-von-Leipzig

@Mirko-von-Leipzig Mirko-von-Leipzig commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

User batches were being rebuilt from individual transactions. At the time this was easier to implement, this PR instead skips the batch builder entirely for these transaction sets. This makes more sense in the context of batch fee collection.

Part of #2501.

Changelog

[[entry]]
scope       = "node"
impact      = "fixed"
description = "Preserve user-submitted batch proofs instead of rebuilding the batches."

@Mirko-von-Leipzig Mirko-von-Leipzig changed the title fix: preserve user-submitted batch proofs fix(sequencer): preserve user-submitted batch proofs Sep 16, 2026
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title fix(sequencer): preserve user-submitted batch proofs Preserve user-submitted batch proofs Sep 16, 2026
@Mirko-von-Leipzig
Mirko-von-Leipzig marked this pull request as ready for review September 16, 2026 13:53

@kkovaacs kkovaacs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mirko-von-Leipzig
Mirko-von-Leipzig removed this pull request from stack #2569 September 17, 2026 11:59
@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2641 September 17, 2026 12:01

@igamigo igamigo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mirko-von-Leipzig
Mirko-von-Leipzig removed this pull request from stack #2641 September 18, 2026 09:45
@Mirko-von-Leipzig
Mirko-von-Leipzig added this pull request to stack #2649 September 18, 2026 09:47
@Mirko-von-Leipzig
Mirko-von-Leipzig force-pushed the mirko/preserve-user-batch-proofs branch from 7535b01 to a32c8a0 Compare September 18, 2026 10:12
@Mirko-von-Leipzig
Mirko-von-Leipzig force-pushed the mirko/preserve-user-batch-proofs branch from a32c8a0 to 2b7512b Compare September 18, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants