feat(env): add explicit Infisical binding in CLI and Dashboard - #51
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Global --create is silently ignored, and workspace binding can persist stale session results when login changes mid-operation.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds explicit Infisical binding across the CLI and Dashboard, replacing implicit project creation during secret writes.
Changes:
- Adds workspace/global binding commands, APIs, validation, locking, and conflict handling.
- Introduces bilingual Dashboard binding dialogs and updated secret workflows.
- Updates tests, help snapshots, localization, and documentation.
| File | Description |
|---|---|
packages/cli/tests/e2e/snapshot_e2e_ux_test.go |
Tests unbound write rejection. |
packages/cli/tests/e2e/snapshot_e2e_tty_unix_test.go |
Adds binding fixture. |
packages/cli/tests/e2e/e2e_helpers_test.go |
Creates bound workspace fixtures. |
packages/cli/testdata/reference/help/env.txt |
Updates env help. |
packages/cli/testdata/reference/help/env_set.txt |
Documents required binding. |
packages/cli/testdata/reference/help/env_bind.txt |
Expands bind help. |
packages/cli/internal/transport/http/responses.go |
Maps manifest conflicts to HTTP 409. |
packages/cli/internal/transport/http/handlers_workspaces.go |
Registers workspace binding route. |
packages/cli/internal/transport/http/handlers_workspace_mutate.go |
Implements binding handler. |
packages/cli/internal/transport/http/handlers_workspace_bind_test.go |
Tests binding API behavior. |
packages/cli/internal/transport/cobra/env/set.go |
Removes implicit initialization progress. |
packages/cli/internal/transport/cobra/env/render.go |
Renders binding results. |
packages/cli/internal/transport/cobra/env/render_test.go |
Tests localized output. |
packages/cli/internal/transport/cobra/env/global.go |
Adds workspace/global bind dispatch. |
packages/cli/internal/transport/cobra/env/global_test.go |
Tests global binding behavior. |
packages/cli/internal/transport/cobra/env/bind.go |
Implements workspace bind flow. |
packages/cli/internal/transport/cobra/env/bind_test.go |
Tests workspace binding. |
packages/cli/internal/platform/i18n/locales/zh-CN.json |
Adds Chinese binding strings. |
packages/cli/internal/platform/i18n/locales/en-US.json |
Adds English binding strings. |
packages/cli/internal/platform/errors/codes.go |
Updates binding remediation. |
packages/cli/internal/modules/environment/target.go |
Adds explicit binding service. |
packages/cli/internal/modules/environment/service.go |
Includes bind in command guidance. |
packages/cli/internal/modules/environment/result.go |
Defines binding result payload. |
packages/cli/internal/modules/environment/operations.go |
Requires existing bindings for writes. |
packages/cli/internal/modules/environment/global.go |
Exposes default global binding. |
packages/cli/internal/modules/environment/binding_test.go |
Tests binding consistency and conflicts. |
packages/cli/internal/application/manifest/service.go |
Serializes manifest publication. |
packages/cli/internal/adapters/env/infisical/shared_location.go |
Adds default global binding behavior. |
packages/cli/internal/adapters/env/infisical/init.go |
Adds pre-write revision validation. |
apps/docs/content/tutorials/zh/infisical-login.mdx |
Updates Chinese global setup tutorial. |
apps/docs/content/tutorials/zh/env-vars.mdx |
Documents explicit workspace binding. |
apps/docs/content/tutorials/en/json-output-error-codes.mdx |
Updates Infisical remediation. |
apps/docs/content/tutorials/en/infisical-login.mdx |
Updates global setup tutorial. |
apps/docs/content/tutorials/en/env-vars.mdx |
Documents explicit workspace binding. |
apps/docs/content/docs/zh/manifest.md |
Updates manifest binding semantics. |
apps/docs/content/docs/zh/login.md |
Documents Dashboard binding flow. |
apps/docs/content/docs/zh/error-codes.md |
Updates binding remediation. |
apps/docs/content/docs/zh/env-vars.md |
Expands Chinese binding reference. |
apps/docs/content/docs/zh/create.md |
Clarifies creation behavior. |
apps/docs/content/docs/en/manifest.md |
Updates manifest binding semantics. |
apps/docs/content/docs/en/login.md |
Documents Dashboard binding flow. |
apps/docs/content/docs/en/error-codes.md |
Updates binding error guidance. |
apps/docs/content/docs/en/env-vars.md |
Expands binding reference. |
apps/docs/content/docs/en/create.md |
Clarifies creation behavior. |
apps/dashboard/src/router/routes.test.tsx |
Updates routing expectations. |
apps/dashboard/src/locales/zh-CN.json |
Adds Chinese Dashboard strings. |
apps/dashboard/src/locales/en-US.json |
Adds English Dashboard strings. |
apps/dashboard/src/features/workspace-settings/WorkspaceSettingsDialog.tsx |
Always exposes secret management. |
apps/dashboard/src/features/workspace-settings/WorkspaceEnvironmentSettings.tsx |
Adds binding controls. |
apps/dashboard/src/features/secrets/SecretsManager.tsx |
Requires explicit binding before writes. |
apps/dashboard/src/features/secrets/SecretsManager.test.tsx |
Tests binding and secret workflows. |
apps/dashboard/src/features/infisical-binding/InfisicalBindingDialog.tsx |
Implements binding dialog. |
apps/dashboard/src/features/global-variables/LocationPicker.tsx |
Integrates picker with binding flow. |
apps/dashboard/src/features/global-variables/GlobalVariables.tsx |
Uses the shared binding dialog. |
apps/dashboard/src/features/global-variables/GlobalVariables.test.tsx |
Tests global binding confirmation. |
apps/dashboard/src/api/workspace.ts |
Adds workspace binding API client. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.