fix: verify trimpath release binaries correctly - #55
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The metadata checks, behavioral smoke tests, regression coverage, and documentation are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects release verification for -trimpath binaries and validates linker-injected values behaviorally.
Changes:
- Validate source, platform, CGO, clean-tree, and trimpath metadata.
- Smoke-test localized help, release channel, and skill-source commit externally.
- Add regression coverage and bilingual release documentation.
| File | Description |
|---|---|
scripts/release.mts |
Expands release smoke verification. |
scripts/release-rules.mts |
Adds build-metadata validation. |
scripts/release-rules.test.mts |
Tests trimpath metadata handling. |
RELEASING.md |
Documents the corrected verification flow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release verification incorrectly expected linker flags in
go version -m, which omits them for the existing-trimpathbuild. Validate the actual source revision, clean-tree state, OS, architecture, CGO setting, and trimpath metadata instead, then check the host binary's version, release channel, and exact skill-source commit through its behavior.Verify help against the source locale catalogs and run workspace smoke fixtures outside the repository. Add a regression case for trimpath metadata and update the bilingual release instructions.
Validation: nine release-rule tests and TypeScript checking passed; all five actual v0.1.17 archives passed the corrected metadata checks; the host binary passed version, both locale/help outputs, templates, the manual-upgrade worker, and recorded skill-source checks. Full
mise run checkpassed.