Repository navigation
feat: unify Windows and macOS builds (v0.3.0) - #2
Merged
Merged
Conversation
Use one product name on both platforms, make the protoc script work from sh and cmd.exe, and split the workflows into a reusable build that tests and packages on Windows and macOS, a CI run for pull requests, and a tag release that publishes both platforms together. CI also starts the packaged app, checks that it does not multiply its processes, and closes it to confirm every process exits.
Rewrite the READMEs for the combined Windows and macOS project and align the macOS version with the Windows numbering.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 982162bee7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Show the window before mitmproxy sets up the proxy servers, since that step can stall and previously left the app running with nothing on screen. Close the window at once when the user closes it, route Cmd+Q through the same path on macOS, and add a watchdog that exits the proxy process shortly after the window process ends for any reason. The packaged-app check now requires the window process to be present and every process to be gone after the window closes.
A single-file build unpacks itself into a temporary directory on every start and removes it on exit. The WinDivert driver file loaded from that directory stays in use after the program closes, so the removal failed and the launcher was left showing a warning dialog. A folder build has nothing to clean up. The Windows download becomes a zip of that folder, and the documents and release notes describe the new close behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes this repository build and release both platforms from one codebase so it can be proposed back to blead/gfl2logger.
gf2logger.apptogfl2logger.app, the window title matches on both platforms, and the version moves to v0.3.0, continuing the Windows numbering after v0.2.5..zipinstead of a single.exe. The single-file launcher could not remove its temporary directory on exit becauseWinDivert64.sysstays in use, and was left showing a warning dialog.build.ymltests and packages onwindows-latestandmacos-15;ci.ymlruns it for pull requests and pushes tomaster;release.ymlruns it for av*.*.*tag and publishes one release with all three files. The tag must matchversion.py.Verification
On both
windows-latestandmacos-15:Not verified
A live capture session against the Windows PC client. The Windows capture mode (
local:GF2_Exilium) is unchanged from v0.2.5.