Skip to content

Remove donor-repo (bbb-scraper, etsy) leftovers - #3

Merged
jehrr merged 2 commits into
mainfrom
fix/donor-leftovers
Sep 28, 2026
Merged

jehrr merged 2 commits into
mainfrom
fix/donor-leftovers

Conversation

@jehrr

@jehrr jehrr commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Text, data and code carried over from the donor repos, which described BBB (and, in the issue templates, Etsy) as if they were Weibo.

Fixes

  • diff_runs.py tracked BBB's columns (rating_grade, city, complaints_total, …), none of which a Weibo row has, so it could never report a change. Now tracks this repo's columns (body, engagement counts, author, region, media); a body change accompanied by a text_source change is source_changed (§8). BBB's sort and 225-row-cap refusals, which could not fire here, removed; hot-feed runs get a note that added/removed is feed churn. --help said bbb-scraper. Verified by hand on sample_output-derived files (changed / source_changed / removed all reported correctly).
  • scraper_api_client.py printed "BBB did not serve the Scraper API's request" with BBB measurements, behind state == "blocked" — a state page_flow.STATE_POLICY does not define, so the branch was dead. Now page_flow.counts_as_blocked(state) with a Weibo message (login wall).
  • captcha_solver.py: BBB Cloudflare docstring and "not here" note replaced with the README's Weibo measurements.
  • CONTRIBUTING.md: BBB-specific sections (markup anchors, sort, page cap, Cloudflare markers, forms, scope, canary secret) rewritten from this repo's README.
  • Issue templates: Etsy prose/URLs replaced; link to non-existent TROUBLESHOOTING.md replaced.
  • claude*.yml secret hint → 2scraper/weibo-scraper; .dockerignore bbb_businesses.* → weibo_posts.* (the engines' --out default); Dockerfile example --out /out/restaurants (and a duplicated --pages); SECURITY.md Cloudflare mention; product_parser provenance names "the sibling bbb-scraper".
  • README: release badge removed — gh release list shows no release.

Kept

  • The "runs without an account" badge: honest for the three modes this repo implements (README measures all three with no account/key/proxy); the login wall is on routes this repo does not read.
  • Sibling provenance: product_parser §21 note (now names bbb-scraper as a sibling), smoke_test's note about the donor Business class, .gitignore craigslist note, captcha_solver farfetch/foodpanda notes, output_writer quora notes.
  • Released [0.1.0] CHANGELOG section untouched.

Suite: 5736 checks green before and after; ci_checks.py sample/secret/help checks green.

🤖 Generated with Claude Code

Petr and others added 2 commits September 28, 2026 19:50
- diff_runs.py: track Weibo's own columns instead of BBB's (none of which a
  Weibo row has), key source_changed on text_source, drop BBB's sort and
  page-cap refusals, note hot-feed churn; fix the --help description.
- scraper_api_client.py: replace the "BBB did not serve" error and its BBB
  measurements; the branch compared against a "blocked" state page_flow
  does not define, so it now uses page_flow.counts_as_blocked.
- captcha_solver.py: replace BBB's Cloudflare prose with what was measured
  on Weibo (no challenge rendered; Yidun and GeeTest preloaded; login wall
  and 21-byte navigation 403 are not solvable).
- CONTRIBUTING.md: rewrite the BBB-specific sections from the README.
- Issue templates: replace Etsy prose and URLs; drop the link to a
  TROUBLESHOOTING.md this repo does not have.
- claude*.yml secret hint, .dockerignore prefix (weibo_posts.*), Dockerfile
  example --out, SECURITY.md Cloudflare mention, product_parser provenance
  wording.
- README: drop the release badge (no GitHub release exists yet).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- captcha_solver.py's docstring pointed at a "No DataDome solver" section this
  repo does not have; the line came with the copied core. Removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jehrr
jehrr force-pushed the fix/donor-leftovers branch from f1d22a1 to 49a169c Compare September 28, 2026 19:50
@jehrr
jehrr merged commit c5a886c into main Sep 28, 2026
7 checks passed
@jehrr
jehrr deleted the fix/donor-leftovers branch September 28, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant