Repository navigation
Coverage is not a thing we measure - #684
Merged
Merged
Conversation
3lvis
marked this pull request as ready for review
September 17, 2026 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Coverage is not a signal this project acts on, so the machinery that produces it is cost without a decision behind it.
AGENTS.mdalready says tests guard against regressions rather than coverage, and the job's own comment concedes the rest — "never fails CI and is intentionally not a required check". An informational number nobody gates on is a report nobody reads.It was not cheap to produce. The job ran
swift test --enable-code-coverageon HEAD, then checked out the pull request base and ran the whole suite a second time to compute a delta — two full macOS test runs per pull request, on the slowest runner we pay for, for a number with no consequence.The approach
The
core-coveragejob andscripts/core_coverage.pyare gone. The gates that remain all fail a pull request when they go red: the macOS test matrix, the three warnings gates, doc links, the perf regression ceiling, the simulator tier, and oida.swift buildclean, lint clean.