Repository navigation
oida 0.17.1, and a scope that reads as written - #686
Merged
Merged
Conversation
3lvis
marked this pull request as ready for review
September 17, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.17 measures a scope from where the run starts rather than from the absolute path on disk, which is a breaking change for any pattern anchored with a leading
/. This repository had two:On 0.17.1 the old pattern matches nothing, so
docs/fell into scope and the prose rules started firing on working notes —docs/project/reactive-reads.mdalone produced a page of them. The anchored form restores what the comment above it always claimed.Verified from both sides rather than from a clean run, since a scope that matches nothing also reports clean: a planted violation in
AGENTS.mdand inLEARNINGS.mdis caught, the same violation indocs/project/faq.mdis not.This is the fix #50 asked for, arriving as the semantics rather than as a warning: a pattern can no longer be written against a checkout directory name, which is what made the old one fragile.
Lint clean,
swift buildclean, no source touched.