fix(connect): close review validation gates - #112
Merged
Merged
Conversation
The Windows carrier recorded a2cc9025… as headerSha256 while the committed header hashes 7b4b4472… on every LF checkout: `core.autocrlf=true` handed the build CRLF bytes and the build path wrote them into the committed record, so a consumer could not verify the header the carrier documents. - `.gitattributes` pins the header to `text eol=lf`. It is hashed into the published carrier record, so its checked-out bytes must not depend on the checkout's end-of-line conversion; `text` still normalizes CRLF to LF on commit, so a CRLF blob cannot reach the repository either. - `tooling/connect/cpp-build.mjs --verify --target <triple>` is the read-only consumer check: it hashes the committed header and staged native and fails when the record no longer describes them. The build path cannot report this drift because it re-records whatever it just hashed. - The binding README documents the check next to the provenance contract. Evidence: throwaway repo, clone with `-c core.autocrlf=true` — without the attribute the checkout is CRLF and hashes a2cc9025… (the recorded win-x64 value); with it the checkout is LF and hashes 7b4b4472…. `--verify` passes for osx-arm64 and reports the win-x64 header mismatch (exit 1); that recorded hash is refreshed by a genuine Windows rebuild, never by editing the record.
A required PR context can never be satisfied when the workflow that owns it is filtered out of the PR, so `ci.yml` (paths-ignore), `cpp-connect.yml`, `docs.yml` and `xcframework.yml` (paths) drop their pull_request filters. Push filters, job names, job semantics and workflow_dispatch are unchanged, and the workflow comments now state why the PR side is unfiltered. The two carrier lanes additionally run the new read-only provenance check (`cpp-build.mjs --verify` for their own RID) before anything rebuilds, so a header/native byte drift fails the lane instead of being rewritten into the record. Note for the ruleset owner: `connect-identity` runs always but its proof step is still gated on the changed-path diff, and `release.yml` reuses the verify-codegen/typescript/rust/verify-version names on pull_request:closed only, so it cannot supply those contexts before merge.
Line 190 of `.mstar/specs/connect-publish-strategy.md` had collapsed into a literal ellipsis, dropping the "Current package reality" dependency list, the "Session-core ownership" rationale and part of the criterion reference. Restored verbatim from 54c97d6 (the commit before #110) with only the version fact updated, `rust-libp2p 0.56` → `0.57`; the file now differs from 54c97d6 by that single token on that single line.
The two committed carriers are ~6 MB each (`spoke_connect_capi.dll` 5.60 MB, `libspoke_connect_capi.dylib` 6.25 MB) and every refresh rewrote them in full, so `.gitattributes` now routes `bindings/cpp/native/**/*.dll` and `**/*.dylib` through LFS the way the Swift xcframework already is. The staged blobs become pointers whose oids are the previous blob hashes, so the binary content is unchanged — no rebuild and no hand-edited artifact, and git history is not rewritten. The Windows import library (`spoke_connect_capi.dll.lib`, 151 KB) and `provenance.json` stay ordinary blobs: they are small, and every checkout — including the lanes that only read or diff the record — must resolve them without an LFS fetch. Go / Kotlin / Python natives are untouched. Both `cpp-connect.yml` lanes now check out with `lfs: true`, so the symbol check, the C++ smoke, the provenance check and the uploaded refresh artifact all see real bytes rather than pointers.
…gers Consumer acquisition paths for the C/C++ channel — `README.md`/`README_CN.md`, `docs/how-to/connect-cpp-binding.md`, `docs/how-to/connect-native-bindings.md`, `docs/packages/quick-start.md` and each CN twin — now carry the `git lfs install` / `git lfs pull` step and say which files stay plain git objects; EN/CN heading parity is unchanged. `CONTRIBUTING.md` gains the git-lfs prerequisite, a "Refreshing the C carrier natives" section (CI artifact → `git add --renormalize` staging → `--verify`), the current required-check set with the rule that a new PR validation check is registered in the `main` ruleset required checks in the same round, and the corrected xcframework trigger (every pull request, not only FFI-surface changes). `.mstar/specs/connect-binding-channels.md` records both facts in its packaging table and §3.6, and the binding README notes the LFS boundary beside the committed natives.
…drift A failing verify step cancelled the rest of the Windows lane, so a stale `provenance.json` also blocked the build, the smoke and the uploaded `spoke-connect-win-x64` artifact — exactly the input the record has to be refreshed from. `Verify committed provenance` now carries `id: provenance` + `continue-on-error: true`, and a final `Fail on provenance drift` step reads that step's raw *outcome* and throws unless it was `success`. So the lane still goes red while the committed bytes disagree (fail-closed, nothing absorbed), but the refresh artifact is produced in the same run and the record can be replaced by a genuine rebuild rather than a hand-edit. The macOS lane keeps a hard failure: it produces no artifact, so nothing downstream has to run for the drift to be actionable.
`connect-identity` is a required PR check, but its proof step was gated on a `git diff` of `tooling/connect-identity-proof/`, `packages/spoke-connect-ts/` and `ci.yml` — on any other PR the context reported success without running the proof, which is indistinguishable from a real pass. The gate step is removed (along with the `fetch-depth: 0` checkout it needed), so the proof runs on every pull request and on pushes to `main`. The job README, the TS-route spec's identity-proof section and the identity parity knowledge note described the removed path filter; they now state the unfiltered rule and why it is deliberate.
Two knowledge notes still described the pre-fix triggers, so their facts now contradicted the workflows. Minimal factual updates, `last_updated: 2026-09-22`: - `ci-assembled-committed-native-artifacts.md`: part 1 is "Required-check CI assembly" — `xcframework.yml` runs on every pull request because `xcframework` is a required check, and only the push side keeps the FFI-surface filter; the re-verify note and the "Non-FFI PR" example say the same. Push-filter and dispatch facts are unchanged. - `integrator-docs-site-ssot-links.md`: the docs build/deadlink gates run unfiltered on pull requests (`Build docs site` is required); the push side keeps the `docs/**` + `tooling/docs/**` filter.
… index L2 review I-1: two directly affected knowledge surfaces still described the required PR gates as path-filtered. - `.mstar/knowledge/README.md`: the identity-parity row said the `connect-identity` job was "(Node 24, fail-open path filter)" and the native-artifact row said "path-filtered build". Both now state the current fact — every pull request for a required check — and keep the push-side filter where it is real. Row source cells record the 2026-09-22 revision. - `tooling-decisions/connect-swift-xcframework-ios-matrix.md` (lines 44-45): the assembly sentence and the re-verify clause now distinguish unfiltered `pull_request` execution from the retained push-side FFI-surface filter; `last_updated: 2026-09-22`. No tests/build/lint/format run; documentation-only facts, no executable surface touched.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.dlland.dylibfiles in Git LFS, with hydrated CI checkouts and consumer instructions. Keep the import library and provenance in ordinary Git.Verification
Verified commit:
b445521f4f0bdcade29d58b2bd20362e7db484b8.core.autocrlf=truecheckout retains the LF header hash.Delivery
This PR is ready for maintainer confirmation after acceptance review. Merge and any subsequent release require explicit approval. The existing
v0.14.0release and repository history remain unchanged.