Skip to content

TEST: Let a property the client script populates have no value #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Automation51D merged 1 commit into from
Sep 18, 2026
Merged

TEST: Let a property the client script populates have no value #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions device-detection.cloud/src/test/java/fiftyone/devicedetection/cloud/ValueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,27 @@ public static void valueTypes(WrapperCloud wrapper) throws Exception {

assertNotNull("Value of " + property.getName() + " is null. ", value);
assertTrue(AspectPropertyValue.class.isAssignableFrom(value.getClass()));
AspectPropertyValue<?> propertyValue =
(AspectPropertyValue<?>) value;
// A property the 51Degrees client script populates, such
// as HasWebDriver or IsVisible, has no value at all on a
// request that carries no client script evidence, and
// this request carries none. Asking such a value for its
// type throws, so what is checked here is that the reason
// for there being no value was given, which is what a
// caller reads.
if (propertyValue.hasValue() == false) {
assertNotNull("Property '" + property.getName() +
"' has no value and no reason was given.",
propertyValue.getNoValueMessage());
continue;
}
assertTrue("Value of '" + property.getName() +
"' was of type " + ((AspectPropertyValue<?>) value).getValue().getClass().getSimpleName() +
"' was of type " + propertyValue.getValue().getClass().getSimpleName() +
" but should have been " + expectedType.getSimpleName() +
".",
expectedType.isAssignableFrom(
((AspectPropertyValue<?>) value).getValue().getClass()));
propertyValue.getValue().getClass()));
}
}
}
Expand Down
19 changes: 17 additions & 2 deletions ...ion.shared/src/test/java/fiftyone/devicedetection/shared/testhelpers/data/ValueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,27 @@ public static void valueTypes(Wrapper wrapper) throws Exception {
expectedType = property.getType();
assertNotNull("Value of " + property.getName() + " is null. ", value);
assertTrue(AspectPropertyValue.class.isAssignableFrom(value.getClass()));
AspectPropertyValue<?> propertyValue =
(AspectPropertyValue<?>) value;
// A property the 51Degrees client script populates, such
// as HasWebDriver or IsVisible, has no value at all on a
// request that carries no client script evidence, and
// this request carries none. Asking such a value for its
// type throws, so what is checked here is that the reason
// for there being no value was given, which is what a
// caller reads.
if (propertyValue.hasValue() == false) {
assertNotNull("Property '" + property.getName() +
"' has no value and no reason was given.",
propertyValue.getNoValueMessage());
continue;
}
assertTrue("Value of '" + property.getName() +
"' was of type " + ((AspectPropertyValue<?>) value).getValue().getClass().getSimpleName() +
"' was of type " + propertyValue.getValue().getClass().getSimpleName() +
" but should have been " + expectedType.getSimpleName() +
".",
expectedType.isAssignableFrom(
((AspectPropertyValue<?>) value).getValue().getClass()));
propertyValue.getValue().getClass()));
}
}
}
Expand Down
Loading