Repository navigation
Keep the channel user list tracked after an attendance reply - #324
Merged
Merged
Conversation
updateChannelUserList replaced the TrackedArray with the plain members array from the response. Later join and leave updates mutated that plain array, so the sidebar stopped re-rendering. Sockethub now answers IRC attendance queries with the same single members message as XMPP (sockethub/sockethub#1308), which made this reachable on IRC too.
raucao
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sockethub is changing the IRC attendance query to answer with one
querymessage carryingobject.members(and arolesmap), the same shape XMPP already uses, instead of one presence update per nick (sockethub/sockethub#1308, closes sockethub/sockethub#277).Hyperchannel already handles that shape in
updateChannelUserList, and the IRC room id in the response (#channel@host) matchessockethubChannelId, so nothing breaks on the wire. JOIN, PART, and WHO still arrive as before.One side effect:
updateChannelUserListreplaced the channel'sTrackedArraywith the plainmembersarray. LateraddUser/removeUsercalls then mutated an untracked array, so joins and parts after the attendance reply stopped re-rendering the sidebar. XMPP had this already; with the Sockethub change IRC would hit it too. This wraps the members in aTrackedArray.Not done: showing op/voice from the new
rolesmap.LinkToUsernamestill derives the role from a@/%/+prefix that Sockethub strips, and no stylesheet styles those classes yet, so there is nothing to render until the UI wants it.Tests: added assertions for the tracked list and an IRC-shaped attendance response.
pnpm test:emberpasses (212 pass, 3 skipped).