Repository navigation
Docs: exact Home, Manage tag and browser wording on "Which tags work" - #105
Merged
Merged
Conversation
Carries the still-valid parts of cdce6c1 (branch claude/eager-albattani- 1r7zcq) onto the page as rewritten for NFC-A detection in 1.0.1-beta.5: tables with the exact wording for a blank tag and for a tag that can't be used, the protection rule for blocks 0-77 (checked in OpenPrintTagWriter::read, refused only for blocks below 78), the row for ISO 15693 tags the reader refuses (geometry over 4096 bytes or blocks over 32 bytes, with both messages), and the two-tag message in the test steps. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QcYr11a5B65kS64MagbgF1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the other session's commit cdce6c1 (branch
claude/eager-albattani-1r7zcq, "Docs: bring 'Which tags work' up to date with the firmware") onto the page as it is onmainafter #103, where that commit no longer merges cleanly.Kept, each checked against the code:
refresh_home_page,tag_flow.hpp,product.js,web_assets.cpp).OpenPrintTagWriter::readreads the lock state of all 80 blocks but refuses withTag has protected blocksonly for a block below 78, and only when writing or clearing. The tag is still read and shown.NFC-V tag geometry is invalid or too largecomes fromTagGeometry::validate()for more than 4096 bytes,Unsupported NFC-V geometryfromReadOnlyService::read_tagfor blocks over 32 bytes. The original commit named only the second.COMPATIBLE BLANK TAG.Dropped: the NTAG/MIFARE row, since #103 changed what happens for those tags.
Docs checks (privacy, mkdocs strict, site validation) pass locally. Once this is merged, branch
claude/eager-albattani-1r7zcqcan be deleted.Generated by Claude Code