Update shumlib from upstream - #2
Merged
Merged
Conversation
Co-authored-by: R Sharp <r-sharp@users.noreply.github.com>
Collaborator
Author
|
@bschroeter Seems I can't add a reviewer- maybe rules we inherited from upstream? |
Collaborator
Author
|
Turns out this workflow doesn't make the references in the upstream available when Spack tries to fetch a specific ref. I'm going to merge the head of upstream with a local branch and use that to test. |
Collaborator
Author
|
@bschroeter Confirmed bitwise identical results with the current head of our fork. |
bschroeter
approved these changes
Jun 12, 2026
Whyborn
pushed a commit
that referenced
this pull request
Jun 23, 2026
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings fork of
shumlibin line with upstream, in preparation for including the bi-linear extrapolation fix.