Repository navigation
fix(plugins): support username-based RBAC login in Burp and browser extensions - #384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both plugins still send only
passwordto/api/auth/login. Since RBAC requires a username, even a correct web-login password fails with HTTP 400:用户名不能为空,且不能超过 64 个字符.Changes
admin, to both plugins and submitusernamewithpassword. Custom RBAC accounts use their own username.Validation
BURP_API_JAR=/tmp/csai-burp-extender-api.jar bash scripts/test-plugin-auth.shpassed: both login clients, admin/custom accounts, JSON escaping and exact password preservation, empty/overlong usernames, failed login, browser settings migration and no password persistence, and Burp account-switch token invalidation.build.sh).git diff --checkpassed.Validation uses local HTTP fixtures and headless Swing components; a live Burp/Chromium session against a running CyberStrikeAI server has not been exercised.