aspeed-g7-pinctrl: pinctrl functions for I2C14 and I2C15 - #316
Conversation
|
Tested on morocco-0257 root@morocco-0257:~# dmesg output before the patch: dmesg output after the patch: |
There are no functions named DI2C14 and DI2C15, only function declaration for I2C14 and I2C15. FUNC_DECL_(I2C14, "I2C14", "DI2C14"); FUNC_DECL_(I2C15, "I2C15", "DI2C15"); So change the function names to I2C14 and I2C15. This fixes such errors displayed by dmesg command: aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function DI2C14 in map table aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function DI2C15 in map table Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
0f36719 to
7bfd6b1
Compare
|
|
||
| pinctrl_di2c15_default: di2c15_default { | ||
| function = "DI2C15"; | ||
| function = "I2C15"; |
There was a problem hiding this comment.
Please make sure that the host is reachable on both the A1 and A2 with and without the rework,
|
This looks good to me. Might be worth while to double check with the upstream that nothing else changed for aspeed-g7-pinctrl. https://github.com/AspeedTech-BMC/linux/blob/121cd93bba48651ad236160e876389bc5b513a16/arch/arm64/boot/dts/aspeed/aspeed-g7-pinctrl.dtsi#L1121 |
|
This change is needed only for 6.18 of the Linux kernel. In 6.8, we have and there is a function declaration FUNC_DECL_(DI2C15, "DI2C15"); In 6.18, FUNC_DECL_(DI2C15, "DI2C15"); So we have to change to In morocco-0257, without this change, busses |
There are no functions named DI2C14 and DI2C15,
only function declaration for I2C14 and I2C15.
FUNC_DECL_(I2C14, "I2C14", "DI2C14");
FUNC_DECL_(I2C15, "I2C15", "DI2C15");
So change the function names to I2C14 and I2C15.
This fixes such errors displayed by dmesg command:
aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
DI2C14 in map table
aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
DI2C15 in map table