Skip to content

aspeed-g7-pinctrl: pinctrl functions for I2C14 and I2C15 - #316

Open
spargaon wants to merge 1 commit into
integ_sp8from
FWDEV-228273-review
Open

aspeed-g7-pinctrl: pinctrl functions for I2C14 and I2C15#316
spargaon wants to merge 1 commit into
integ_sp8from
FWDEV-228273-review

Conversation

@spargaon

@spargaon spargaon commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

There are no functions named DI2C14 and DI2C15,
only function declaration for I2C14 and I2C15.

FUNC_DECL_(I2C14, "I2C14", "DI2C14");
FUNC_DECL_(I2C15, "I2C15", "DI2C15");

So change the function names to I2C14 and I2C15.

This fixes such errors displayed by dmesg command:

aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
DI2C14 in map table

aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
DI2C15 in map table

@spargaon

spargaon commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

Tested on morocco-0257

root@morocco-0257:~#

dmesg output before the patch:
[ 1.495681] aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function DI2C15 in map table
[ 1.486489] aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function DI2C14 in map table

dmesg output after the patch:
[ 1.487418] aspeed-g7-soc1-pinctrl 14c02400.pinctrl: found group selector 190 for DI2C14
[ 1.498219] aspeed-g7-soc1-pinctrl 14c02400.pinctrl: found group selector 191 for DI2C15

There are no functions named DI2C14 and DI2C15,
only function declaration for I2C14 and I2C15.

FUNC_DECL_(I2C14, "I2C14", "DI2C14");
FUNC_DECL_(I2C15, "I2C15", "DI2C15");

So change the function names to I2C14 and I2C15.

This fixes such errors displayed by dmesg command:

aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
  DI2C14 in map table

aspeed-g7-soc1-pinctrl 14c02400.pinctrl: invalid function
  DI2C15 in map table

Signed-off-by: Shirish Pargaonkar <Shirish.Pargaonkar@amd.com>
@spargaon
spargaon force-pushed the FWDEV-228273-review branch from 0f36719 to 7bfd6b1 Compare September 2, 2026 03:57
@spargaon
spargaon requested a review from mahkurap September 2, 2026 15:34
Comment thread arch/arm64/boot/dts/aspeed/aspeed-g7-pinctrl.dtsi

pinctrl_di2c15_default: di2c15_default {
function = "DI2C15";
function = "I2C15";

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that the host is reachable on both the A1 and A2 with and without the rework,

@spargaon
spargaon requested a review from mahkurap September 2, 2026 15:53
@amd-knieman

Copy link
Copy Markdown
Collaborator

@spargaon

spargaon commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

This change is needed only for 6.18 of the Linux kernel.

In 6.8, we have

    pinctrl_di2c15_default: di2c15_default {
            function = "DI2C15";
            groups = "DI2C15";
    };

and there is a function declaration

FUNC_DECL_(DI2C15, "DI2C15");


In 6.18,

FUNC_DECL_(DI2C15, "DI2C15");
changed to
FUNC_DECL_(I2C15, "DI2C15");

So we have to change

    pinctrl_di2c15_default: di2c15_default {
            function = "DI2C15";
            groups = "DI2C15";
    };

to
pinctrl_di2c15_default: di2c15_default {
function = "I2C15";
groups = "DI2C15";
};

In morocco-0257, without this change, busses
i2c14 and i2c15 are not detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants