fix(tests): isolate pytest discovery and loader tests from global con… - #303
Open
mgarguk wants to merge 1 commit into
Open
fix(tests): isolate pytest discovery and loader tests from global con…#303mgarguk wants to merge 1 commit into
mgarguk wants to merge 1 commit into
Conversation
Contributor
|
Thanks for picking up #302 @mgarguk / @factictionary, the approach matches what we already do elsewhere in Before we can merge, please:
Short CHANGELOG entry woudl be also good. We may follow up with a shared Thanks for contributing! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fig (fixes #302)
Description
Type of Change
skills/skills/skillware/core/loader, env, adaptersskillware/cli.py,docs/usage/cli.mdexamples/*.py, agent loops,examples/README.mdpyproject.toml,MANIFEST.inChecklist (all PRs)
Fixes #…orRefs #…)python -m black --check .andflake8pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevantCHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable scriptpytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedNew or updated skill
Skip unless this PR adds or changes files under
skills/.Bundle and metadata
skills/<category>/<skill_name>/(fromtemplates/python_skill/or equivalent)manifest.yaml:name(full ID),version,description,parameters,constitution, realissuershort_description,issuer.github,issuer.org,requirements,env_varsLogic, cognition, tests
skill.py(no ad-hoc LLM-generated execution paths)instructions.mdexplains when and how to use the skillcard.jsonissuer matches manifest when presenttest_skill.pycovers execution and schema expectationsSkillLoader.load_skill("<category>/<skill_name>")succeeds (or deps documented)Documentation and catalog
docs/skills/<skill_name>.mdand row indocs/skills/README.mdConstitution and safety (skills only)
Related Issues