Skip to content

feat: add ARUSSim launch without SLAM using ground truth (ideal_slam) - #100

Open
Marcos-Valera wants to merge 2 commits into
mainfrom
feature/slam/arussim_without_slam
Open

Marcos-Valera wants to merge 2 commits into
mainfrom
feature/slam/arussim_without_slam

Conversation

@Marcos-Valera

Copy link
Copy Markdown

Adds sim_no_slam_launch.py and an ideal_slam node that replaces graph_slam using the simulator ground truth

@@ -0,0 +1,5 @@
ideal_slam:
ros__parameters:
sensor_max_dist: 40.0 # m Cones farther than this are not added to the map (lidar_max_dist)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take care, it is seem that we see so much than before

Comment thread src/arussim/src/ideal_slam.cpp Outdated
min_lap_distance_ = this->get_parameter("min_lap_distance").as_double();

tf_broadcaster_ = std::make_shared<tf2_ros::TransformBroadcaster>(this);
map_pub_ = this->create_publisher<sensor_msgs::msg::PointCloud2>("/slam/map", 10);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harcoded

Comment thread src/arussim/src/ideal_slam.cpp Outdated

tf_broadcaster_ = std::make_shared<tf2_ros::TransformBroadcaster>(this);
map_pub_ = this->create_publisher<sensor_msgs::msg::PointCloud2>("/slam/map", 10);
lap_count_pub_ = this->create_publisher<std_msgs::msg::Int16>("/slam/lap_count", 10);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harcoded

Comment thread src/arussim/src/ideal_slam.cpp Outdated
tpl_sub_ = this->create_subscription<std_msgs::msg::Bool>(
"/arussim/tpl_signal", 10, std::bind(&IdealSlam::tpl_callback, this, std::placeholders::_1));
reset_sub_ = this->create_subscription<std_msgs::msg::Bool>(
"/arussim/reset", 1, [this](std_msgs::msg::Bool::SharedPtr) { reset(); });

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harcoded

Comment thread src/arussim/src/ideal_slam.cpp Outdated

geometry_msgs::msg::TransformStamped tf;
tf.header.stamp = this->now();
tf.header.frame_id = "arussim/world";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

harcoded

Comment thread src/arussim/src/ideal_slam.cpp Outdated
cone.z = track_[i].z;
cone.data[3] = 1.0f;
// Like the simulated perception, only blue and yellow are colored (orange and TPL cones are uncolored)
cone.color = (track_[i].color == 0 || track_[i].color == 1) ? track_[i].color : -1;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slam did not decide the color. Our planning decides it when pass through them

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what these lines do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is make more sense to make the launch on common_meta and do not change unnecessary code. Usually we use arussim's launch when car will not run for example stats

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants