Repository navigation
Clear the Checkmarx critical and high findings from the 11/09 scan - #36
Merged
Merged
Conversation
The scan of main (123cfb2) reported one critical Stored XSS and one high Client DOM XSS from AJAX: - tests/e2e/lib/Cdp.php put the raw CDP handshake response into an exception message. It now reports a fixed message instead. - frontend/AdminLTE3_ComVer/js/main.js defined changeBlock(), which wrote an AJAX response straight into the DOM. Nothing calls it (UrlModal uses its own changeBlockUrlModal), so it is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Checkmarx scan of
main(123cfb2) on 2026-11-09 reported one critical and one high finding. Release requires both levels to be 0.tests/e2e/lib/Cdp.php:36frontend/AdminLTE3_ComVer/js/main.js:97changeBlock(), which wrote an AJAX response into the DOM. Nothing calls it;UrlModaluses its ownchangeBlockUrlModal()The high finding was first reported now because this scan included
frontend/(243,700 LOC / 1,119 files vs 108,205 / 485 on 10/22).main.jsitself is unchanged since the initial release.Verification
main.js.No screen behavior changes.
🤖 Generated with Claude Code