Repository navigation
Stop shipping LLVMSupport and LLVMDemangle in the release packages - #363
Merged
Merged
Conversation
Since #333 no compiled program links an LLVM library: the linker never gets the --llvm-lib-path folder, only the default-lib build environment and the cmake/vscode templates do. Drop LLVMSupport.lib from the Windows zip and libLLVMSupport.a/libLLVMDemangle.a from the Linux tarballs, and from the memory-model measuring script's link line. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
#333 took LLVMSupport, LLVMDemangle and ntdll out of the CMake template's link libraries, but --cmake and --new still read the LLVM lib path into an LLVM_LIB_PATH substitution. No CMake template uses it, and the VSCode tasks and launch configurations passed it only as --llvm-lib-path, which tslang ignores. Drop the substitution and those arguments. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #333 no compiled program links an LLVM library.
--llvm-lib-path/LLVM_LIB_PATHis still accepted, but it never reaches the linker.Release packages
LLVMSupport.lib.libLLVMSupport.aandlibLLVMDemangle.a.TSLANG_DEBUG_CRTcomment that listedLLVMSupport.libamong the shipped /MT libraries.scripts/measure_memory_model.ps1: dropLLVMSupport.liband the LLVM/libpathfrom its link line.Project templates (
--cmake,--new)#333 already took LLVMSupport, LLVMDemangle and ntdll out of the CMake template's link libraries. What was left: both scaffolds still read the LLVM lib path into an
LLVM_LIB_PATHsubstitution that no CMake template uses, and the VSCode tasks/launch configurations passed it as--llvm-lib-path, which tslang ignores. Both are gone.Tested: tslang Release builds clean. Freshly generated
--cmakeand--newprojects contain nollvmorntdllreference, and each VSCode task keeps its gc/tslang/default-lib path arguments. The release workflow runs only on a tag, so the packaging change is not verified by a run.Companion: DefaultLib comment fix, ASDAlexander77/TypeScriptCompilerDefaultLib#11.
🤖 Generated with Claude Code