Repository navigation
test-compile-async-without-collector runs on Linux too - #421
Merged
Merged
Conversation
#419's split of the async runtime applies to the static library on Linux as well, and before it the failure was the same there: checked in WSL at #418, the scheduler's object (AsyncRuntime.cpp.o) referenced GC_allow_register_threads, GC_register_my_thread, GC_unregister_my_thread and GC_get_stack_base, and 00async_await.ts built with `tslang --emit=exe` under rc, none and own failed to link ("undefined reference to `GC_register_my_thread'"). At main only AsyncGCThreads.cpp.o references them, and all four models link and run at -O0 and -O3. The test was registered for Windows only; async-without-collector.cmake passes as is on Linux, so the guard goes. Its comments name both platforms' messages and linkers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns on
test-compile-async-without-collector(from #419) on Linux. It was registered for Windows only, and the script passes on Linux as it is.Checked in WSL (Ubuntu, release)
At #418, before the split, Linux had the same bug.
AsyncRuntime.cpp.oinlibTypeScriptAsyncRuntime.a) referencedGC_allow_register_threads,GC_register_my_thread,GC_unregister_my_threadandGC_get_stack_base.00async_await.tsbuilt withtslang --emit=exefailed to link under rc, none and own, at -O0 and -O3:At main (b213b9a):
AsyncGCThreads.cpp.oreferences those functions.async-without-collector.cmakepasses, both standalone and under ctest on this branch.00async_gc_threading.tsunder gc had 0 failures in 20 runs at -O0 and 20 at -O3. The pool threads still register with the collector on Linux.The Linux CI job passed on #419 without showing any of this. Its tests link through
test-runner, which always adds-lgc.Change
CMakeLists.txt: theif (WIN32)guard around the registration goes.async-without-collector.cmake: the comments now name both platforms' link errors, and say that the runner links the collector on both.🤖 Generated with Claude Code