Repository navigation
docs/bugs: remove the fixed repros; C interop notes move to the docs - #558
Merged
Merged
Conversation
Every repro in docs/bugs passes on main, or fails as TypeScript does: the native_ts_graphics findings were fixed by #535-#544 and #549 (the `let s = 0` one by design, with a warning since #544), testFallThrough, generic_in_generic and array_of_ifaces_cast by #538, #542 and #543, and bug14 and bug21 aren't valid TypeScript. Each fix has its regression test in tslang/test/tester, and the findings document is in the history and in those PRs, so the folder goes. Its interop notes stay, in docs/c-cpp-header-import.md: a `string` returned by a C function is its `char*`, not a copy; `number` is a `double`; and a nullable `Ref<T>` field is spelled `Ref<T> | null`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every repro in
docs/bugswas re-run onmain(Release,--emit=jit) and now passes, or fails as TypeScript does:ntg_opaque_nullable_compare,ntg_boolean_array_elements,ntg_template_literal_escape,ntg_and_nullable_class,ntg_math_max_negative,ntg_jit_cache_import(_lib)donentg_let_zero_is_integers32); warns since #544testFallThrough,generic_in_generic,array_of_ifaces_castbug14,bug21new (x: this) => x)Each fix has its regression test in
tslang/test/tester, so the repros andnative-ts-graphics-findings.md(all entries closed) are removed. Its interop notes move todocs/c-cpp-header-import.md:stringreturned by a declared C function is thechar*itself, not a copy (checked in the emitted IR);numberis a Cdouble;Ref<T>field is writtenRef<T> | null.The open items from the second round of native_ts_graphics findings are fixed in #556 (64-bit shifts) and #557 (implicit derived constructor, plus error locations).
🤖 Generated with Claude Code