Fix joined-player laser cadence and muzzle position - #33
Merged
Merged
Conversation
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sbddesign
marked this pull request as ready for review
September 6, 2026 19:23
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A joining Wasp could sound like it was firing far faster than the host and draw new lasers behind its predicted hull. The same three-second, 100 ms each-way latency probe reproduces this on both pre-lobby
6a73896and lobbye74a47c: 26 host volleys, 309 local laser sounds, and all 25 newly received local bolts behind the ship (up to 49 units).Restore the weapon cooldown with snapshots and keep reconciliation silent. Fresh prediction emits one local-pitch sound per volley and cosmetic tracers at the predicted muzzle. Delayed local authoritative bolts remain in the snapshot but are hidden while prediction is active. Cosmetic collisions cannot call ship damage; the host still decides hits and scoring. Session/snapshot protocol is now v3, so both players must reload the same build.
This is a separate fix for a pre-existing bug, stacked on #32 (
feat/lobby) because it extends the snapshot protocol. Merge #32 first; its implementation is unchanged.Validation at
1dac6ae(includes main’s BFG change and the resolved lobby):Preview: https://neon-orbit-git-fix-client-weapons-delineatormedia.vercel.app/?host=2
Typecheck/simulation/balance/build passed locally. Full local and GitHub mutation gates pending on the merged head.