Conversation
Contributor
审查者指南更新 MaaEnd 配置指南以匹配新版 AUTO-MAS/MaaEnd 集成能力,覆盖安装、脚本与用户配置、自动采集和送货等新增任务选项,并补充版本兼容性及分辨率使用说明。 MaaEnd 任务阶段选择流程图flowchart LR
Start[开始托管] --> Delivery[送货阶段]
Delivery --> Daily[日常任务阶段]
Daily --> Collect[自动采集阶段]
Collect --> End[任务结束]
Daily --> End
文件级变更
提示与命令与 Sourcery 交互
自定义使用体验访问你的控制面板即可:
获取帮助Original review guide in EnglishReviewer's Guide更新 MaaEnd 配置指南以匹配新版 AUTO-MAS/MaaEnd 集成能力,覆盖安装、脚本与用户配置、自动采集和送货等新增任务选项,并补充版本兼容性及分辨率使用说明。 Flow diagram for MaaEnd task stage selectionflowchart LR
Start[开始托管] --> Delivery[送货阶段]
Delivery --> Daily[日常任务阶段]
Daily --> Collect[自动采集阶段]
Collect --> End[任务结束]
Daily --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
嘿——我发现了 3 个问题
面向 AI Agent 的提示
请处理本次代码审查中的评论:
## 单独评论
### 评论 1
<location path="docs/script-guide/maaend.md" line_range="51" />
<code_context>
- | **(PC端)游戏启动参数** | 留空 |
- | **(PC端)游戏启动后等待时间** | 启动游戏后等几秒再开始操作,默认 60 秒 |
- | **任务完成后关闭游戏** | 全部用户跑完后要不要自动关掉游戏 |
+ | **(PC端)游戏路径** | 选 `Endfield.exe`,**不是**鹰角启动器 | '
+ | **(PC端)启动时设置分辨率** | 启用后,会在运行MaaEnd时将分辨率设为720P,避免不符合分辨率要求 |
+ | **(PC端)结束时恢复分辨率** | 启用后,会在全部任务结束时恢复到设定的分辨率,全屏或指定的分辨率 |
</code_context>
<issue_to_address>
**小问题:** PC 游戏路径表格行的结尾 `|` 后多了一个撇号,因此渲染后的文档会显示多余的 `'`,并且该行与其他表格行相比格式不正确。
**建议修复:** 删除该行末尾的撇号。
</issue_to_address>
### 评论 2
<location path="docs/script-guide/maaend.md" line_range="55" />
<code_context>
+ | **(PC端)启动时设置分辨率** | 启用后,会在运行MaaEnd时将分辨率设为720P,避免不符合分辨率要求 |
+ | **(PC端)结束时恢复分辨率** | 启用后,会在全部任务结束时恢复到设定的分辨率,全屏或指定的分辨率 |
+ | **(PC端)游戏启动参数** | 无需要则留空 |
+ | **(PC端)游戏启动后等待时间** | 无需填写,已由MaaEnd接管 |
+ | **任务完成后关闭游戏** | 用户跑完后要不要自动关掉游戏 |
| **代理超时限制** | 日志多少分钟没动静就算卡死,默认 10 分钟 |
</code_context>
<issue_to_address>
**问题:** 配置表说明启动等待时间已由 MaaEnd 控制,无需再填写;但故障排除部分仍然告诉用户不要降低默认的 60 秒等待时间。按照更新后的配置指南操作、将 AUTO-MAS 等待时间字段留空的用户,没有明确的方法来应用故障排除建议,并且这两条说明相互矛盾。
**触发条件:** 游戏启动较慢,且用户在将 AUTO-MAS 等待时间字段留空后,按照故障排除部分的说明进行操作时。
**建议修复:** 更新故障排除部分,指出控制等待时间的 MaaEnd 设置;或者删除已经过时的 60 秒调整建议。
</issue_to_address>
### 评论 3
<location path="docs/script-guide/maaend.md" line_range="124" />
<code_context>
-
-
+### 每天仅一次的任务
+顾名思义,添加后每天只会执行一次/
+### 任务前后额外脚本
+与通用脚本一致的功能,支持在任务完成前/后额外执行您指定的程序或脚本。
</code_context>
<issue_to_address>
**小问题:** 新句子以字面上的 `/`(`每天只会执行一次/`)结尾,因此发布后的文档会包含一个明显的多余字符,句子也不完整。
**建议修复:** 将末尾的 `/` 替换为适当的中文标点,或将其删除。
```suggestion
顾名思义,添加后每天只会执行一次。
```
</issue_to_address>Sourcery 评估
等待批准。 请先处理 1 个发现的问题。
阻塞性发现:docs/script-guide/maaend.md:55
Original comment in English
Hey - I've found 3 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/script-guide/maaend.md" line_range="51" />
<code_context>
- | **(PC端)游戏启动参数** | 留空 |
- | **(PC端)游戏启动后等待时间** | 启动游戏后等几秒再开始操作,默认 60 秒 |
- | **任务完成后关闭游戏** | 全部用户跑完后要不要自动关掉游戏 |
+ | **(PC端)游戏路径** | 选 `Endfield.exe`,**不是**鹰角启动器 | '
+ | **(PC端)启动时设置分辨率** | 启用后,会在运行MaaEnd时将分辨率设为720P,避免不符合分辨率要求 |
+ | **(PC端)结束时恢复分辨率** | 启用后,会在全部任务结束时恢复到设定的分辨率,全屏或指定的分辨率 |
</code_context>
<issue_to_address>
**nitpick:** The PC game-path table row contains an extra trailing apostrophe after the closing `|`, so the rendered documentation displays a stray `'` and the row is malformed compared with the other table rows.
**Suggested fix:** Remove the trailing apostrophe after the row.
</issue_to_address>
### Comment 2
<location path="docs/script-guide/maaend.md" line_range="55" />
<code_context>
+ | **(PC端)启动时设置分辨率** | 启用后,会在运行MaaEnd时将分辨率设为720P,避免不符合分辨率要求 |
+ | **(PC端)结束时恢复分辨率** | 启用后,会在全部任务结束时恢复到设定的分辨率,全屏或指定的分辨率 |
+ | **(PC端)游戏启动参数** | 无需要则留空 |
+ | **(PC端)游戏启动后等待时间** | 无需填写,已由MaaEnd接管 |
+ | **任务完成后关闭游戏** | 用户跑完后要不要自动关掉游戏 |
| **代理超时限制** | 日志多少分钟没动静就算卡死,默认 10 分钟 |
</code_context>
<issue_to_address>
**issue:** The configuration table says the startup wait time no longer needs to be filled because MaaEnd controls it, while the troubleshooting section still tells users to avoid lowering the default 60-second wait time. Users following the updated configuration guidance have no clear way to apply the troubleshooting advice, and the two instructions contradict each other.
**Triggers:** When the game starts slowly and the user follows the troubleshooting section after leaving the AUTO-MAS wait-time field empty.
**Suggested fix:** Update the troubleshooting section to identify the MaaEnd setting that controls the wait time, or remove the obsolete 60-second adjustment advice.
</issue_to_address>
### Comment 3
<location path="docs/script-guide/maaend.md" line_range="124" />
<code_context>
-
-
+### 每天仅一次的任务
+顾名思义,添加后每天只会执行一次/
+### 任务前后额外脚本
+与通用脚本一致的功能,支持在任务完成前/后额外执行您指定的程序或脚本。
</code_context>
<issue_to_address>
**nitpick:** The new sentence ends with a literal `/` (`每天只会执行一次/`), so the published documentation contains an obvious stray character and does not read as a complete sentence.
**Suggested fix:** Replace the trailing `/` with the intended Chinese punctuation or remove it.
```suggestion
顾名思义,添加后每天只会执行一次。
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: docs/script-guide/maaend.md:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcery 摘要
更新 MaaEnd 支持文档,使其与当前配置功能保持一致,并提供更清晰的设置指南。
新功能:
错误修复:
增强功能:
文档:
Original summary in English
Sourcery 总结
更新 MaaEnd 支持文档,提供与当前配置功能一致且更清晰的设置指南。
改进:
文档:
Original summary in English
Summary by Sourcery
更新 MaaEnd 支持文档,提供与当前配置功能一致且更清晰的设置指南。
Enhancements:
Documentation: