pyImathTest: compare array vs scalar quaternion results with a tolerance (#515) - #597
Merged
cary-ilm merged 1 commit intoSep 14, 2026
Conversation
…nce (AcademySoftwareFoundation#515) Signed-off-by: Moira Shooter <mshooter@ilm.com>
mshooter-ilm
added a commit
to mshooter-ilm/Imath
that referenced
this pull request
Sep 14, 2026
…ademySoftwareFoundation#597 Signed-off-by: Moira Shooter <mshooter@ilm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
testQuatArrayscompared results of array operations (slerp,*= inverse(),normalized()) bit-exactly against the equivalent scalar operations. Vectorized and non-vectorized code paths can legitimately differ in the last few bits, and on aarch64, ppc64le, riscv64, s390x and loongarch64 they do (issue #515).Solution:
This adds a small
quatEqualhelper using the file's existing 1e-5 tolerance and uses it for those comparisons on all platforms; plain copies are still compared exactly.Split out of #596 (python wheels), whose Linux arm64 wheel test needs it.