fix: Repair bad string formatting - missing args, dangerous format spec - #2145
Merged
Merged
Conversation
RendererServices default implementations of errorfmt(), warningfmt(),
etc, passed the formatted error string directly to Context::errorfmt()
as the sole argument, like
context->errorfmt(some_string);
But even though it's a single plain string with no intentional
arguments to format, what if that string happens to containing
std::format-like formatting directives, like "{hello world}", that
will confuse the heck out of the underlying string formatting engine?
The correct code all along was:
context->errorfmt("{}", any_string_ok_here);
Also happened to find a use of fmt in typecheck.cpp where it didn't pass an
argument implied by the format spec.
Additionally, for safety in a somewhat related way, make
decode_message not crash, and print debug info, if the underlying
format_to_n throws an exception.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Aug 17, 2026
…ec (AcademySoftwareFoundation#2145) RendererServices default implementations of errorfmt(), warningfmt(), etc, passed the formatted error string directly to Context::errorfmt() as the sole argument, like context->errorfmt(some_string); But even though it's a single plain string with no intentional arguments to format, what if that string happens to containing std::format-like formatting directives, like "{hello world}", that will confuse the heck out of the underlying string formatting engine? The correct code all along was: context->errorfmt("{}", any_string_ok_here); Also happened to find a use of fmt in typecheck.cpp where it didn't pass an argument implied by the format spec. Additionally, for safety in a somewhat related way, make decode_message not crash, and print debug info, if the underlying format_to_n throws an exception. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RendererServices default implementations of errorfmt(), warningfmt(), etc, passed the formatted error string directly to Context::errorfmt() as the sole argument, like
But even though it's a single plain string with no intentional arguments to format, what if that string happens to containing std::format-like formatting directives, like "{hello world}", that will confuse the heck out of the underlying string formatting engine? The correct code all along was:
Also happened to find a use of fmt in typecheck.cpp where it didn't pass an argument implied by the format spec.
Additionally, for safety in a somewhat related way, make decode_message not crash, and print debug info, if the underlying format_to_n throws an exception.