Repository navigation
Conversation
…ht disagree The throw surfaces as noisy Sentry errors in apps where the mismatch is harmless. Log a warning instead.
If didInsertElement throws before the ResizeSensor is created, teardown of the aborted render calls willDestroyElement with _tableResizeSensor still null and masks the original error with a TypeError.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small robustness fixes found while running ember-table in a production app.
ember-theadwillDestroyElement: ifdidInsertElementthrows before theResizeSensoris created, teardown of the aborted render callswillDestroyElementwith_tableResizeSensorstillnull. The resultingTypeErrormasks the original error. The teardown now checks for the sensor first.getScale: whenoffsetHeightand the computed height disagree it threw. In apps where the mismatch is harmless this surfaced as noisy error-reporting events. It now logs a warning instead.No behavior change on the happy path.