Frontend test hardening + docs sync (rebased onto develop) - #20
Merged
Merged
Conversation
added 5 commits
August 30, 2026 13:02
Remove dead code and hedged assertions that let implementations drift: - drop ghost "state.path" writes (no such property; guards key off currentPath) - drop the 250ms waits (the debounce lives in App.svelte's $effect, not in the store functions the tests call directly; a 0ms flush suffices) - assert the /preview payload strictly (names as strings, sanitized config) - assert duplicateNames as a plain array (the store assigns res.names) - exercise interpolation with a real key (rename.confirmMsg) instead of a fake key that only works via the unknown-key fallback
Adds the two test files identified in the suite review and expands the
store/component smoke tests:
- lib/api.test.js: response parsing + error mapping (10 tests),
including the new {path, dirs} payload contract
- modifiers smoke: all seven panels (toggle class, bindings,
conditional inputs, grey-out) as a second component layer (21 tests)
- store: goUp bounds, refreshPreview guards, checkDuplicates,
performRename happy + 409 paths, dialog resolution semantics
(13 -> 27 tests)
- components smoke: RenameButton dialog paths mount the Dialog host
alongside; ModifierCard gets a proper (raw) snippet as children and
real DataTransfer drag events
Frontend suite: 48 -> 98 tests, all passing. Svelte 5 flushes DOM
updates on a later tick, so DOM assertions follow an explicit settle.
The panels greyed out via CSS only (opacity + pointer-events: none),
which blocks the mouse but not the keyboard: users could Tab into a
"disabled" panel and edit its config, and assistive tech reported
the controls as enabled. Wrap the controls in <fieldset disabled> —
the attribute cascades a real disabled state to every input and
select — and keep the opacity as the visual cue (dropping
pointer-events).
Remove's range inputs already used real disabled attributes for their
sub-option gating and compose with the fieldset unchanged; the
sub-option split becomes a stated rule in AGENTS.md: mode-only
inputs render conditionally ({#if}), persistent-value inputs
disable via attribute.
Tests now assert the fieldset's disabled attribute (a strictly
stronger check than the old class check).
The Range checkbox shared its row with the from/to values and the until-end checkbox, which read as one crowded strip. Give the toggle its own row and let the range values (from, to, until end) group on the row below — the only row that still dims while range is off (the toggle itself no longer greys out, since it is the control that turns the section back on). DOM input order is unchanged, so the existing tests need no selector updates.
Addi90
force-pushed
the
test/frontend-hardening
branch
from
August 30, 2026 12:40
5aece15 to
0b8fb06
Compare
- AGENTS.md: DESIGN.md + index.css in repo layout; App.svelte line now reflects theme toggle and breadcrumb path bar; new theming bullet in frontend essentials; dark mode no longer an open item - README.md: mention the light/dark theme toggle; DESIGN.md in layout - DESIGN.md: point token reference at frontend/src/index.css (the prototype lives on a separate branch) - drop superseded plan.md (directory renaming shipped in 0.3.0)
Addi90
force-pushed
the
test/frontend-hardening
branch
from
August 30, 2026 12:55
0b8fb06 to
b95d940
Compare
Addi90
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<fieldset disabled>(keyboard + AT), and puts Remove's range toggle on its own row