Repository navigation
Keep clearing room fog from the office seen from the rooftop - #393
Open
rjnetwork212 wants to merge 1 commit into
Open
rjnetwork212 wants to merge 1 commit into
rjnetwork212 wants to merge 1 commit into
Conversation
…stemLabs#392) Sky.setRoof zeroed skyClearRooms and skyInside together, so on the roof office/garage fragments got the full outdoor haze even though the interior below is still indoor. Zero only skyInside (lamplight) there; leave skyClearRooms at 1 unless an enclosed map is in play. setIndoors still zeroes both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sky.setRoofzeroedskyClearRoomstogether withskyInside. ButskyInOfficeis a world-space box test, so office-interior fragments below the roof kept getting full outdoor fog even though they are indoors.setRoofnow only zeroesskyInside(office/garage lamplight) and leavesskyClearRoomsat 1, so room fog clearing stays on while on the roof.setIndoors(enclosed maps like the castle) still zeroes both, since those maps have no office/garage room boxes to clear. Regular office/garage floors are unchanged.Tests
tests/sky-fog.test.tsnow asserts the roof keepsskyClearRooms= 1 whileskyInside= 0, and that enclosed maps still zero both.npm run typecheck✅npm test✅ (614 pass)npm run build✅AGENT_OFFICE_WEATHER=fog, from the rooftop looking down over the edge: office-interior fragments render clear with this change, fully hazed without it.