Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex workers on Windows answer normally but their lifecycle hooks exit with code 1. Without SessionStart/Stop reports, the office keeps showing needs input after the turn finishes. POSIX single quoting fails in cmd, and simply double-quoting the executable still fails in Codex's PowerShell environment executor.
Change
Use a fixed Windows
node.exe -ecommand with the generated helper's absolute path in a per-worker environment variable. Prepend the office's Node installation to that worker's PATH. Paths never enter cmd/PowerShell expansion, including spaces, Unicode, apostrophes and shell metacharacters. POSIX commands and native hook trust/approval behavior stay intact. Document the update/resume procedure.Validation
npm run typecheckandnpm run buildpass./hooks, and observedidle -> working -> doneafter a response.npm testwas attempted on Windows: 556/616 passed, 60 failed. This is not a green full suite: failures include client registry path separators, clone fixtures and provider executable fixtures; three stuck fixture subprocesses were terminated to finish the run. A separate Codex worker-fixture run also failed to launch its fixture executables. The actual Windows CLI round trip above passed.No frontend change.