Skip to content

PORT-004: Keep LinkedIn profile links consistent #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ajthompson88 merged 1 commit into from
Sep 19, 2026
Merged

PORT-004: Keep LinkedIn profile links consistent #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/Contact.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
FaGithub,
} from "react-icons/fa";
import { FiDownload, FiMail } from "react-icons/fi";
import { PROFILE_LINKS } from "../constants/profileLinks";

const Contact = () => {
const [status, setStatus] = useState("idle");
Expand Down Expand Up @@ -56,8 +57,8 @@ const Contact = () => {
<a href="/Andrew_Thompson_Resume.pdf" target="_blank" rel="noreferrer" className="button-secondary"><FiDownload aria-hidden="true" /> Résumé</a>
</div>
<div className="mt-6 flex gap-5">
<a href="https://www.linkedin.com/in/andrew-thompson-dev-442477aa" target="_blank" rel="noopener noreferrer" className="social-link"><FaLinkedinIn aria-hidden="true" /> LinkedIn</a>
<a href="https://github.com/Ajthompson88" target="_blank" rel="noopener noreferrer" className="social-link"><FaGithub aria-hidden="true" /> GitHub</a>
<a href={PROFILE_LINKS.linkedin} target="_blank" rel="noopener noreferrer" className="social-link"><FaLinkedinIn aria-hidden="true" /> LinkedIn</a>
<a href={PROFILE_LINKS.github} target="_blank" rel="noopener noreferrer" className="social-link"><FaGithub aria-hidden="true" /> GitHub</a>
</div>
</div>

Expand Down
5 changes: 3 additions & 2 deletions src/components/Hero.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// src/components/Hero.jsx
import { FaGithub, FaLinkedinIn } from "react-icons/fa";
import { FiArrowRight, FiDownload } from "react-icons/fi";
import { PROFILE_LINKS } from "../constants/profileLinks";

export default function Hero() {
return (
Expand All @@ -26,10 +27,10 @@ export default function Hero() {
</div>

<div className="mt-8 flex items-center gap-5 text-sm text-slate-400">
<a className="social-link" href="https://www.linkedin.com/in/andrew-thompson-442477aa" target="_blank" rel="noreferrer">
<a className="social-link" href={PROFILE_LINKS.linkedin} target="_blank" rel="noreferrer">
<FaLinkedinIn aria-hidden="true" /> LinkedIn
</a>
<a className="social-link" href="https://github.com/Ajthompson88" target="_blank" rel="noreferrer">
<a className="social-link" href={PROFILE_LINKS.github} target="_blank" rel="noreferrer">
<FaGithub aria-hidden="true" /> GitHub
</a>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/Contact.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ it('includes direct contact, resume, and social links', () => {

expect(screen.getByRole('link', { name: 'Email' })).toHaveAttribute('href', 'mailto:aj.thompson8888@gmail.com')
expect(screen.getByRole('link', { name: 'Résumé' })).toHaveAttribute('href', '/Andrew_Thompson_Resume.pdf')
expect(screen.getByRole('link', { name: 'LinkedIn' })).toHaveAttribute('href', 'https://www.linkedin.com/in/andrew-thompson-dev')
expect(screen.getByRole('link', { name: 'LinkedIn' })).toHaveAttribute('href', 'https://www.linkedin.com/in/andrew-thompson-dev-442477aa')
expect(screen.getByRole('link', { name: 'GitHub' })).toHaveAttribute('href', 'https://github.com/Ajthompson88')
})
})
4 changes: 4 additions & 0 deletions src/constants/profileLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export const PROFILE_LINKS = {
linkedin: "https://www.linkedin.com/in/andrew-thompson-dev-442477aa",
github: "https://github.com/Ajthompson88",
};
Loading