Repository navigation
Repin EndoForge to main 68eaa75 (macOS durable sync) and make run_status honest - #88
Merged
Merged
Conversation
…atus The vendored EndoForge ledger writer called os.fdatasync, which macOS Python lacks, so every forge goal on macOS failed with "isolate ledger bridge failed: exit 70". Repin with tools/pin_endoforge.py to EndoForge origin/main 68eaa75a0ce5f65b5517077cb736d8d7ffebb755, which syncs through tools/durable.py (F_FULLFSYNC on macOS, else fdatasync, else fsync; endoforge #163). The slice gains tools/durable.py and core/runtime/isolate-wasm-tooling.mjs, now imported by the ledger writer and IsolatePool (27 -> 29 files). No interface in icd-endoforge.md section 8 changed: Ledger and FrozenEvaluators are byte-identical, and IsolatePool only gained optional options Cstack does not pass. cli.py reported run_status "completed" even when the workcell never ran. It now reports completed only when every outcome executed and responded; otherwise stopped, outcome_unknown, failed or not_executed, and a new top-level not_completed list carries each such outcome's status, assessment and limitations. Enforced by RunStatusTests and the NotExecuted forge tests under new requirement CS-REQ-088. Full suite, before -> after: Python 3.13 CI-like venv 71F+3E -> 5F; Python 3.15 on macOS 70F+4E -> 5F. The remaining five are tests/test_workcell_kill.py, whose helpers use GNU ps --ppid and /proc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in #84 to #87. Conflicts resolved by keeping both sides: CHANGELOG.md entries; requirements and verification-matrix revision rows renumbered so main's 2.2 (cstack init) stays and this PR's CS-REQ-088 row becomes 2.3, with each document's Version set to 2.3. EXPORT-MANIFEST.json regenerated with tools/build_export_manifest.py; data dictionary --check passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Akilleez-QA
marked this pull request as ready for review
November 17, 2026 09:58
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
origin/main68eaa75a0ce5f65b5517077cb736d8d7ffebb755(wasea7b8d6), usingtools/pin_endoforge.py --source <clone> --commit 68eaa75….SOURCE-MANIFEST.jsonandcontracts/SOURCE-PINS.jsonrecord this commit withon_main: true. The slice grows from 27 to 29 files: it addsvendor/endoforge/tools/durable.py(portable durable sync:F_FULLFSYNCon macOS, elsefdatasync, elsefsync; endoforge #163), which the ledger writer now imports, andvendor/endoforge/core/runtime/isolate-wasm-tooling.mjs, whichIsolatePooland the WASM limit now import (endoforge #153, #155).os.fdatasync, which macOS Python does not have. On macOS every forge goal failed withisolate ledger bridge failed: exit 70.LedgerandFrozenEvaluatorsare byte-identical.IsolatePoolonly adds two optional settings,toolingWasmModulesandsyncHostCalls, and Cstack sets neither.ENDOFORGE_LEDGER_JOURNALandENDOFORGE_DUMP_LISTare read the same way as before.cli.py.run_statusiscompletedonly when every outcome executed and responded (completedortool_errorwith certaintyresponded). Otherwise it is one of these, in this precedence:stopped,outcome_unknown,failed,not_executed. A new top-levelnot_completedlist givesdecision_id,attempt_id,execution_status,execution_certainty,assessmentandlimitationsfor each outcome that did not run. The rule is a new requirement, CS-REQ-088, enforced bytests/test_process_and_cli.py::RunStatusTests,tests/test_forge_identity.py::NotExecutedandtests/test_workcell_run.py::OneGoal.run_status,not_completed), test plan TP-4, requirements, the verification matrix, the SDD-C9 row and CHANGELOG.EXPORT-MANIFEST.jsonis regenerated.Checks (run on macOS, Darwin, Node 26.13.1; no model calls;
ANTHROPIC_*andCLAUDE_CODE_OAUTH_TOKENunset; stub transport only)python -B -m unittest discover -s tests, Python 3.13 venv withci/requirements.txt, venv on PATH as in CIorigin/main0a9703b): 734 tests, 71 failures + 3 errors; after: 735 tests, 5 failures, 0 errorsci/requirements.txt(the cold-start probe's setup)CSTACK_ENDOFORGE_CLONE=<fetched clone> python -B -m unittest tests.test_endoforge_pin tests.test_pin_endoforge_toolpython -B tools/check_trace.pypython -B tools/check_links.pypython -B tools/gen_data_dictionary.py --checkcompleted workcell_not_executed: the old status claimed success, and the limitations heldisolate ledger bridge failed: exit 70completed candidate_passed assemblyscript 0.28.20 {'foundation_refrigeration': 'js-port'} unavailable,not_completed: []forge.sqlitemade a directory)not_executed, withnot_completed=unavailable / not_dispatched / workcell_not_executed / "Reason: unable to open database file"The before and after suites ran in pairs at the same time, so both had the same load.
Not done
tests/test_workcell_kill.py::Kill. They were already failing onmain. The test helpers use GNUps --ppid(intests/forge_fixtures.py::descendants) and/proc/<pid>/stat(inalive), and macOS has neither, sowait_fortimes out. The product code is not at fault. A portable helper (pgrep -P,ps -o stat=) would fix it; that is a follow-up.first-run.mdwas recorded on Linux and was not re-recorded.🤖 Generated with Claude Code