Skip to content

[PWGCF] EbyE finalized errors on moments using subsampling#17018

Open
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling
Open

[PWGCF] EbyE finalized errors on moments using subsampling#17018
baasingh wants to merge 2 commits into
AliceO2Group:masterfrom
baasingh:featfmsubsampling

Conversation

@baasingh

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the pwgcf label Jul 11, 2026
@github-actions github-actions Bot changed the title PWGCF: EbyE finalized errors on moments using subsampling [PWGCF] EbyE finalized errors on moments using subsampling Jul 11, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 4299406 at 2026-07-11 08:40:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 6 warnings.'
Found 13 errors and 6 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:7: error: variable 'tmpFqErr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:57:7: error: variable 'collisionZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:58:8: error: constructor does not initialize these fields: pdg, binningM, fqEvent, fqEventSampled, binConEvent, binConEventSampled [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:170:16: error: member 'dcaxyMaxTrackPar0' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:171:16: error: member 'dcaxyMaxTrackPar1' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:172:16: error: member 'dcaxyMaxTrackPar2' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:173:16: error: member 'dcazMaxTrack' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:206:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:289:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:42: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:299:73: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:544:10: error: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/00a6e6e3048522fa3654cda503a0d16a36a2a6e7/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:390:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:392:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:394:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:470:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:472:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:474:47: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

alibuild commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for a5e9275 at 2026-07-18 08:15:

## sw/BUILD/O2Physics-latest/log
2026-07-18T08:14:05.562+0200 [24221:139925573058176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.561+0200 [21378:140144531259008] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "FindMissingBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.562+0200 [24905:139950659645056] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.563+0200 [24905:139950659645056] [executioncontext.cpp:739] [ERROR] Failed to download output blob 0a6594ac8c093be720b520e5b62e863628f60d1e7af3d713894c8a38e59dbe80: 14: Socket closed
2026-07-18T08:14:05.561+0200 [25061:140418800791168] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.563+0200 [25061:140418800791168] [executioncontext.cpp:739] [ERROR] Failed to download output blob 33d1db8856af61cd797df63fb0b1580cb0966cab56470016607697c971145182: 14: Socket closed
2026-07-18T08:14:05.561+0200 [20988:140279109385856] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.566+0200 [20988:140279109385856] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.567+0200 [20988:140279109385856] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [23348:140319166062208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.566+0200 [23348:140319166062208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.567+0200 [23348:140319166062208] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.562+0200 [24810:139628318678656] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.565+0200 [24810:139628318678656] [executioncontext.cpp:739] [ERROR] Failed to download output blob de83f634463eea2333d4aaf52aef78732af865237b7fa181efe4ae00fe7f8f04: 14: Socket closed
2026-07-18T08:14:05.561+0200 [24902:139765546507904] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.564+0200 [24902:139765546507904] [executioncontext.cpp:739] [ERROR] Failed to download output blob c3627ff9d33708c5d17b315b669fd411c9336cdd38fe892eaf3d0ceb154a315d: 14: Socket closed
2026-07-18T08:14:05.562+0200 [24934:140542273949312] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.565+0200 [24934:140542273949312] [executioncontext.cpp:739] [ERROR] Failed to download output blob 3715e3fbfc6ea3437db5970a6bf6ea23d18ea695fd41d9ac816502ea68c5e64e: 14: Socket closed
2026-07-18T08:14:05.561+0200 [24957:140389582712448] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.564+0200 [24957:140389582712448] [executioncontext.cpp:739] [ERROR] Failed to download output blob a4b3f0284ee79b24ddb082f72edc40723d5d7413329c4aabbd2094aa9514212f: 14: Socket closed
2026-07-18T08:14:05.561+0200 [20446:139654761954944] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.569+0200 [20446:139654761954944] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.569+0200 [20446:139654761954944] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [21510:140145508064896] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.569+0200 [21510:140145508064896] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.570+0200 [21510:140145508064896] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [21554:140086019010176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.568+0200 [21554:140086019010176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.569+0200 [21554:140086019010176] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [24599:140058993729152] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.568+0200 [24599:140058993729152] [executioncontext.cpp:739] [ERROR] Failed to download output blob b36acc0ffeb88b3526b480b28df7898f3d34025be94673fa7e81449623f31c60: 14: Socket closed
2026-07-18T08:14:05.561+0200 [24744:140382344552064] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.566+0200 [24744:140382344552064] [executioncontext.cpp:739] [ERROR] Failed to download output blob df1a0823606dbbbeaa0e32dcda8f7969a36b7429ca129c5349f3fa9984bb4ec4: 14: Socket closed
2026-07-18T08:14:05.562+0200 [24782:140526340865664] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.566+0200 [24782:140526340865664] [executioncontext.cpp:739] [ERROR] Failed to download output blob acaf1d2533927d28044d57de7744d62971a22ef6c1ae498e9e71358cc8f43684: 14: Socket closed
2026-07-18T08:14:05.561+0200 [24904:140155396750976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.569+0200 [24904:140155396750976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.569+0200 [24904:140155396750976] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [24998:140685932985984] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.567+0200 [24998:140685932985984] [executioncontext.cpp:739] [ERROR] Failed to download output blob b23a570f06075ed763654472f3ab77e38ce7208adaded8dd0fdeb02757b69abd: 14: Socket closed
2026-07-18T08:14:05.561+0200 [25019:140680747314816] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "BatchUpdateBlobs()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.569+0200 [25019:140680747314816] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Write()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.570+0200 [25019:140680747314816] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.UpdateActionResult()", last gRPC error was [14: failed to connect to all addresses; last error: UNKNOWN: ipv4:127.0.0.1:8980: Failed to connect to remote host: Connection refused]
2026-07-18T08:14:05.561+0200 [24706:140090853559936] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.571+0200 [24706:140090853559936] [executioncontext.cpp:739] [ERROR] Failed to download output blob aa1d3e3a3c0c1185e6d921e55ff948931ce67f1ab26f499115a9c89a9aff88a7: 14: Socket closed
2026-07-18T08:14:05.562+0200 [24235:139890623164032] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ByteStream.Read()", last gRPC error was [14: Socket closed]
2026-07-18T08:14:05.580+0200 [24235:139890623164032] [executioncontext.cpp:739] [ERROR] Failed to download output blob 41fed8a873382126b90bc2a9127ffad2b7902cfa56dad068333042687d474a66: 14: Socket closed
2026-07-18T08:14:05.561+0200 [25083:140365191114368] [buildboxcommon_grpcretrier.cpp:177] [ERROR] Retry limit (0) exceeded for "ActionCache.GetActionResult()", last gRPC error was [14: Socket closed]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a5e9275 at 2026-07-18 05:19:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 13 errors and 6 warnings.'
Found 13 errors and 6 warnings.
++ [[ 13 -gt 0 ]]
++ cat /sw/BUILD/32f19dbd4e5c9f9b9f7c7a85e0c6550b3b82a53e/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:50:1: error: included header string_view is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:1: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:56:7: error: variable 'tmpFqErr' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:57:7: error: variable 'collisionZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:58:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:170:16: error: member 'dcaxyMaxTrackPar0' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:171:16: error: member 'dcaxyMaxTrackPar1' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:172:16: error: member 'dcaxyMaxTrackPar2' of type 'const double' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:203:5: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:286:9: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:296:42: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:296:73: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:541:10: error: implicit conversion 'unsigned long long' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/32f19dbd4e5c9f9b9f7c7a85e0c6550b3b82a53e/O2Physics-code-check/warnings.txt
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:387:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:389:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:391:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:467:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:469:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/EbyEFluctuations/Tasks/FactorialMomentsTask.cxx:471:47: warning: statement should be inside braces [readability-braces-around-statements]
++ [[ 13 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants