Repository navigation
feat: Add control for line opacity - #311
Merged
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Default-colored connecting lines do not currently honor the new opacity setting.
2 open findings
What changed in this PR
Adds configurable opacity for plot connection lines across UI, Redux, rendering, and URL state.
Changes:
- Adds line-opacity state, actions, selector, validation, and URL persistence.
- Adds an opacity slider and applies opacity during trace generation.
- Updates URL-state tests and settings labels.
| File | Description |
|---|---|
src/util/UrlState.ts |
Persists line opacity in URLs. |
src/util/test/UrlState.test.ts |
Tests URL serialization and actions. |
src/state/selection/types.ts |
Defines opacity state and action types. |
src/state/selection/selectors.ts |
Exposes opacity to plot settings. |
src/state/selection/reducer.ts |
Stores and validates opacity. |
src/state/selection/constants.ts |
Defines the action constant. |
src/state/selection/actions.ts |
Adds the opacity action creator. |
src/containers/MainPlotContainer/selectors.ts |
Applies opacity to line traces. |
src/constants/index.ts |
Defines the default opacity. |
src/components/PlotLineSettings/index.tsx |
Adds the opacity slider. |
src/components/MainPlot/index.tsx |
Renames the settings heading. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ShrimpCryptid
marked this pull request as ready for review
October 14, 2026 00:05
ShrimpCryptid
requested review from
frasercl and
interim17
and removed request for
a team
October 14, 2026 00:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #306, "Enable opacity for connecting lines".
Solution
Type of change
Screenshots (optional):
Video talk-through (🔊):
2026-10-13.16-07-35.mp4