feat: Migrate to vite by ShrimpCryptid · Pull Request #314 · AllenCell/cell-feature-explorer

ShrimpCryptid · 2026-10-15T16:47:54Z

Problem

Closes #312, "Migrate to vite."

Estimated review size: small, 15-20 minutes

Solution

Switches build tooling to vite from webpack.
Bumps typescript config targeting versions for compatibility with new Vite env variable import style (import.meta.env)
Updates env variable constant patterns.
Removes postcss- and webpack-related dependencies.
- Note that webpack is still installed due to plotly.js dependency.
Removes other unused dependencies from the project.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Steps to Verify:

Open PR preview: https://allencell.github.io/cell-feature-explorer/pr-preview/pr-314/
CFE should render and be interactive as normal.

Screenshots (optional):

Keyfiles (delete if not relevant):

vite.config.js
package.json

github-actions · 2026-10-15T16:50:00Z

PR Preview Action v1.6.3
🚀 View preview at https://AllenCell.github.io/cell-feature-explorer/pr-preview/pr-314/
Built to branch `gh-pages` at 2026-10-15 22:04 UTC. Preview will be ready when the GitHub Pages deployment is complete.

ShrimpCryptid · 2026-10-15T18:02:43Z

+        "vitest": "^3.2.4"
    },
    "dependencies": {
        "@aics/browsing-context-messaging": "~1.1",


I'm fairly certain that this is no longer being used... going to remove it in a follow-up PR

ShrimpCryptid · 2026-10-15T18:04:11Z

-
-| Env var | Default | Options |
-| ------- |-------- |---------|
-|`DEPLOYMENT_ENV`    | dev     | "dev", "staging", "production" |


This env var was not set or used.

Copilot

🟡 Changes recommended

CSS export naming breaks annotation styling, and the default asset base breaks subdirectory-hosted previews.

2 open findings

What changed in this PR

Migrates Cell Feature Explorer from webpack to Vite, addressing #312.

Changes:

Replaces webpack tooling and scripts with Vite.
Moves environment flags to Vite-backed constants.
Updates assets, TypeScript settings, and development documentation.

File	Description
webpack/webpack.config.js	Removes webpack configuration.
webpack/plugins.js	Removes webpack plugins.
webpack/constants.js	Removes webpack-specific constants.
vite.config.js	Configures Vite builds and development.
typings/images.d.ts	Declares image imports.
tsconfig.json	Updates module output setting.
tsconfig.base.json	Updates TypeScript compilation targets.
src/vite-env.d.ts	Declares Vite environment types.
src/styles/README.md	Removes webpack styling documentation.
src/state/image-dataset/reducer.ts	Uses the centralized dataset flag.
src/state/image-dataset/firebase/configure-firebase.ts	Uses the centralized database flag.
src/state/configure-store.ts	Uses the centralized DevTools flag.
src/constants/index.ts	Reads Vite environment flags.
src/components/Icons/index.tsx	Updates the logo import path.
src/assets/images/AICS-logo-full.png	Adds the bundled logo asset.
README.md	Updates local development instructions.
public/images/icon-CFE.png	Adds a public icon asset.
public/images/favicon.ico	Adds the public favicon.
package.json	Replaces webpack scripts and dependencies.
index.html	Adds the Vite application entry point.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

…ive basename

Copilot

🟡 Changes recommended

The ignored basename setting breaks asset loading for subdirectory deployments without an explicit CLI override.

1 open finding

Use Vite's base property for subdirectory asset paths · New

2 resolved since last review

🧠 Review effort: Balanced

frasercl

Looks good! Excited to have fewer dependencies, fewer LOC, fewer plugins, fewer config files...

frasercl · 2026-10-16T21:20:46Z

 import { LoadingOutlined } from "@ant-design/icons";
-import AicsLogoWhite from "../../images/AICS-logo-full.png";
+
+import AicsLogoWhite from "../../assets/images/AICS-logo-full.png";


Just curious (maybe I should know this already)... is there a vite reason that images had to move, or did you just think this was a nicer place to put them? (No problems either way, to be extra clear.)

Moved them just for project organization, to match how we handle it in other projects. Not required though!

frasercl · 2026-10-16T21:30:42Z

frasercl · 2026-10-16T21:30:49Z

KILLING!!!!

ShrimpCryptid commented Oct 15, 2026

View reviewed changes

ShrimpCryptid added this pull request to stack #315 October 15, 2026 18:13

ShrimpCryptid changed the title ~~Feat/use vite~~ feat: Migrate to vite Oct 15, 2026

ShrimpCryptid requested a balanced review from Copilot October 15, 2026 18:13

Copilot started reviewing on behalf of ShrimpCryptid October 15, 2026 18:13

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread vite.config.js

Comment thread vite.config.js Outdated

ShrimpCryptid added 13 commits October 15, 2026 12:42

feat: Installed vite, switched run/build scripts to vite

e6ba125

refactor: Moved images

c9ebe40

fix: Fixed CSS styling

febca3a

refactor: Removed old index.template.html

0ebd8ef

refactor: Update references to CSS tooling, webpack/vite

d1c9f9b

refactor: Remove webpack, postcss

1a2284b

refactor: Remove additional deps

be79b8e

refactor: Removed unused ts-enum-util

306e680

fix: Linting

b84826c

refactor: Remove webpack config

b99a6d9

refactor: Remove unused ENV constant

9b6cc53

refactor: Remove basename property in vite config (vole-specific config)

0f25389

refactor: Use camel case consistently for CSS modules, add vite relat…

ab95983

…ive basename

ShrimpCryptid force-pushed the feat/use-vite branch from 9c1cb07 to ab95983 Compare October 15, 2026 20:00

ShrimpCryptid added 2 commits October 15, 2026 13:03

fix: PR preview build

b46874e

fix: PR preview

a7acfee

ShrimpCryptid requested a balanced review from Copilot October 15, 2026 20:46

Copilot started reviewing on behalf of ShrimpCryptid October 15, 2026 20:46

View session

Copilot AI reviewed Oct 15, 2026

View reviewed changes

Comment thread vite.config.js Outdated

fix: Base argument in vite config

3ff4db3

ShrimpCryptid marked this pull request as ready for review October 15, 2026 21:09

ShrimpCryptid requested a review from a team as a code owner October 15, 2026 21:09

ShrimpCryptid requested review from frasercl and rugeli and removed request for a team October 15, 2026 21:09

frasercl approved these changes Oct 16, 2026

View reviewed changes

rugeli approved these changes Oct 16, 2026

View reviewed changes

Conversation

ShrimpCryptid commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Type of change

Steps to Verify:

Screenshots (optional):

Keyfiles (delete if not relevant):

Uh oh!

github-actions Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-10-15 22:04 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

frasercl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ShrimpCryptid commented Oct 15, 2026 •

edited

Loading

github-actions Bot commented Oct 15, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-10-15 22:04 UTC.
Preview will be ready when the GitHub Pages deployment is complete.