Skip to content

Feature: Restrict chat messages to hard coded messages #1000 - #1005

Merged
tickBit merged 2 commits into
devfrom
1000-feature-restrict-chat-messages-to-hard-coded-messages
Sep 25, 2026
Merged

tickBit merged 2 commits into
devfrom
1000-feature-restrict-chat-messages-to-hard-coded-messages

Conversation

@EemeliJ

@EemeliJ EemeliJ commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Brief description

Restricts chat messages to predefined response types and emotions. Free-text client content is no longer accepted or stored; the frontend localizes messages from responseType while legacy history remains supported.

Change list

  • Require valid responseType and emotion for clan and global WebSocket chat messages.
  • Ignore client-provided content and derive stored content from responseType.
  • Store and broadcast responseType and emotion.
  • Preserve compatibility with legacy history records containing only content.
  • Prevent duplicate WebSocket errors when message validation fails.
  • Update daily-task event payloads to use server-validated chat values.
  • Add and update chat validation, service, gateway, and WebSocket error-handling tests.

closes #1000

@codecov-alt

codecov-alt Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/chat/decorator/wsExceptionFilter.decorator.ts 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/chat/service/clanChat.service.ts 73.68% <ø> (ø)
src/chat/service/globalChat.service.ts 88.88% <ø> (ø)
src/chat/decorator/wsExceptionFilter.decorator.ts 91.66% <75.00%> (+61.66%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tickBit tickBit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me 👍 ! Approved.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Sep 25, 2026
@tickBit
tickBit merged commit c3141cf into dev Sep 25, 2026
5 checks passed
@tickBit
tickBit deleted the 1000-feature-restrict-chat-messages-to-hard-coded-messages branch September 25, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature request: Restrict chat messages to hard-coded messages

2 participants