Centralize scoring configuration in taskConstants.ts - #1006
Merged
tickBit merged 4 commits intoSep 27, 2026
Merged
Conversation
CapoMK25
requested review from
MikhailDeriabin and
hoan301298
as code owners
September 27, 2026 06:15
23 tasks
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
tickBit
approved these changes
Sep 27, 2026
tickBit
left a comment
Collaborator
There was a problem hiding this comment.
Looks very solid 👍 ! Approved.
tickBit
deleted the
995-centralize-scoring-configuration-in-taskconstantsts
branch
September 27, 2026 06:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
Closes issue #995
Implements a centralized scoring config essentially. Removes the requested file on the side. Uses the same structure for now as was mentioned on the issue. Rewrites tests accordingly, Tested via in-memory testing:
Edit: I accidentally deleted 2 comments. I'll add them back in in a later commit on this PR.
Change list
src/__tests__/dailyTasks/dailyTaskScoringValues.test.tssrc/__tests__/matchmaking/MatchmakingService/flow.test.tssrc/__tests__/rewarder/ClanRewarder/rewardForClanEvent.test.tssrc/dailyTasks/consts/taskConstants.tssrc/box/dailyTask/defaultPredefinedDailyTasks.tsand others like it revamped acoording to the new const variables for centralized scoringsrc/common/values/scoring.values.tsas redundant