Skip to content

1007 feature request add a new gametype field to matchroom info and to its endpoints - #1009

Merged
CapoMK25 merged 12 commits into
devfrom
1007-feature-request-add-a-new-gametype-field-to-matchroom-info-and-to-its-endpoints
Sep 28, 2026
Merged

CapoMK25 merged 12 commits into
devfrom
1007-feature-request-add-a-new-gametype-field-to-matchroom-info-and-to-its-endpoints

Conversation

@tickBit

@tickBit tickBit commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Brief description

Related issue #1007

Add a client-defined integer gameType field to matchmaking rooms and propagate it through room responses, invites, active matches, and MQTT notifications. Matchmaking queues now separate rooms by both matchType and gameType, preventing players using different game modes from being matched together.

Testing from command line

Example output:

{
  "data": {
    "Object": {
      "id": "6aba7e35ff228f83b3597265",
      "matchType": "RANDOM",
      "gameType": 1,
      "status": "READY",
      "ownerPlayerId": "69ef8b7332f46bd743f4c54e",
      "players": [
        "69ef8b7332f46bd743f4c54e"
      ],
      "bots": [
        {
          "botId": "6aba7e35ff228f83b3597265:bot:1",
          "displayName": "Bot 1",
          "isBot": true
        }
      ],
      "teamSize": 2,
      "allowBots": true,
      "createdAt": "2026-09-28T14:48:21.130Z",
      "updatedAt": "2026-09-28T14:48:21.130Z",
      "readyAt": "2026-09-28T14:48:21.130Z"
    }
  },
  "metaData": {
    "dataKey": "Object",
    "modelName": "Object",
    "dataType": "Object",
    "dataCount": 2
  }
}

Change list

  • Add required integer gameType validation to the matchmaking room creation DTO.
  • Store gameType in the Redis-backed matchmaking room state.
  • Include gameType in matchmaking room HTTP responses.
  • Include gameType in ROOM_UPDATED, invite, and match MQTT payloads.
  • Propagate gameType from rooms to RANDOM, CLAN, and CUSTOM matches.
  • Separate RANDOM and CLAN Redis queues by matchType and gameType.
  • Prevent rooms with different gameType values from being matched together.
  • Add DTO validation tests for valid, missing, string, decimal, and null values.
  • Add matchmaking flow tests for room, invite, match, and MQTT propagation.
  • Add tests ensuring different game modes remain in separate queues.
  • Verify the changes with 42 passing matchmaking tests, build, ESLint, and diff checks.

@codecov-alt

codecov-alt Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/dailyTasks/dailyTasks.service.ts 75.40% <ø> (ø)
src/dailyTasks/taskGenerator.service.ts 95.45% <100.00%> (ø)
src/matchmaking/matchmaking.service.ts 85.10% <100.00%> (+3.33%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tickBit and others added 4 commits September 28, 2026 18:13
…oom-info-and-to-its-endpoints' of https://github.com/Alt-Org/Altzone-Server into 1007-feature-request-add-a-new-gametype-field-to-matchroom-info-and-to-its-endpoints

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid job, approved.

@CapoMK25
CapoMK25 merged commit 098d97b into dev Sep 28, 2026
5 checks passed
@CapoMK25
CapoMK25 deleted the 1007-feature-request-add-a-new-gametype-field-to-matchroom-info-and-to-its-endpoints branch September 28, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feature request: Add a new GameType field to MatchRoom info and to its endpoints.

2 participants