Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…-players-to-leave-a-matchmaking-room-they-have-previously-joined
CapoMK25
left a comment
There was a problem hiding this comment.
Approved on the code side, solid work.
Is this tested via Postman/in-memory testing or something along those lines? The description didn't say, or I missed it.
|
Tests inside the code are the only tests this PR has been put through. |
|
Then this should be tested via Postman/Bruno/along those lines as the last step, as otherwise the frontend might flag something in the future that's not visible here. |
|
Ok, I will do it tomorrow at the latest. If I find the time to it, I will test this via command line and with Postman tonight later. |
…o-leave-a-matchmaking-room-they-have-previously-joined' of https://github.com/Alt-Org/Altzone-Server into 1008-feature-request-add-a-endpoint-to-allows-players-to-leave-a-matchmaking-room-they-have-previously-joined
|
Everything seemed to work fine, except the returned status code after leaving a matchmaking room was Nest's default: 201. Now leaving room explicitly returns 204. Here's testing output:
Player A can still see the room: |
|
I also tested, that when the player who has created a matchmaking room leaves the room, the other player can still be in the room: This is related to updating the state of the matchmaking room after leaving. |
|
Since the only additions after yesterday's approval are I'll continue with merge dev into main for September then. |
Brief description
Related issue #1008
Adds support for authenticated players to leave their current matchmaking room. Room ownership, matchmaking state, Redis data, bot fillers, and MQTT room updates are handled according to the remaining room composition.
Change list
POST /matchmaking/rooms/leave.NOT_FOUNDwhen the player has no active room.MATCHEDstatus.OPENorREADYstatus.ROOM_UPDATEDnotifications to the remaining players.