Conversation
…dded statistic card styling, simplified the statistics section, aligned the layout with the Figma design, and updated the statistics heading.
…tates, also fixed some positioning and rendering issues with the ellipses and arrows in the timeline
…rectly for sorting dropdown and close button and made some other minor tweaks to dropdown chevron, statcard size and various fonts
… designers personal page, can be expanded later through i18n.
…rdingly to thinner viewport widths
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
One thing i noticed is that: description and keywords are still in the Props interface but are not destructed or used in the component. might wanna remove them from the interface too.
looks like it was just forgotten code.
There was a problem hiding this comment.
Good catch, looks like i forgot to remove them, i'll go ahead and do that next 👍
There was a problem hiding this comment.
You can easily check for lint errors by using npm run lint. This way you wont miss any unused props or other errors like it 😄
Skoivumaki
left a comment
Skoivumaki
left a comment
There was a problem hiding this comment.
Good work!
Some stuff:
-
Make sure the first entry is open, so that the user has something to read when they land on the page.
-
Although you did as in Figma design, I think it looks too crowded. Add some padding between the elements:
…up the page to open the first timeline entry when loaded
Skoivumaki
left a comment
Skoivumaki
left a comment
There was a problem hiding this comment.
Looks good and very fast work. Just to make sure, DropdownWrapper is used in many places, did you check your changes didn't affect them in a negative way? If so the improvements to dropdown were solid 👍
Yes, i took into consideration that 'DropdownWrapper' is used elsewhere, and tried to keep the chances i made to it in the scope of this issue 👍 |
3 participants
📄 Pull Request Overview
Closes #659
🔧 Changes Made
Rebuilt the About / History page
Internationalization and content structure
UI and interaction improvements
Implemented responsive timeline styling and controls across different viewport sizes.
✅ Checklist Before Submission
console.log()or other debugging statements are left. ✅📝 Additional Information
Provide any additional context or information that reviewers may need to know:
Desktop with closed entries:
Open entry in desktop:
Mobile fullsize closed: (Note: the footer and header don't actually behave like this)
Mobile fullsize with open entries:
Actual look of mobile upper and lower areas:
-Upper:
-Lower:
Ipad:
-Upper:
-Lower:
Translations:
