feat: add Transactions findOne/findMany [AMB-2992] - #49
Merged
wthrajat merged 1 commit intoAug 25, 2026
Merged
Conversation
The schema already exposes find_one/find_many on the transaction namespace, but transactions.graphql never declared operations for them, so the typed client never got the methods. Add GetTransaction and ListTransactions operations, regenerate the SDK, and wrap them on Transactions, mirroring the existing Wallets.get/list pattern.
bufo24
force-pushed
the
jesseva/amb-2992-payments-sdk-transactions-exposes-no-findonefindmany-forcing
branch
from
August 25, 2026 09:03
49b8357 to
1772207
Compare
bufo24
marked this pull request as ready for review
August 25, 2026 09:03
wthrajat
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transactions(packages/payments/src/resources/transactions.ts) only exposedcreateReceiveandsend, even though the GraphQL schema already hasfind_one/find_manyon the transaction namespace (TransactionQueriesinpackages/payments/src/generated/sdk.ts). The gap was purely client-side:packages/payments/src/operations/transactions.graphqlnever declared operations for them.GetTransaction(find_one) andListTransactions(find_many) queries totransactions.graphql, plus aSimplePaymentsTransactionFieldsfragment and aFindManyTransactionsFieldsfragment (list + pagination + total_count), and regeneratedsrc/generated/sdk.tsviapnpm --filter @ambosstech/payments run codegen.Transactions.findOne(id)andTransactions.findMany(input), mirroring the existingWallets.get/Wallets.listpattern.findManyreturns thefind_manyresult as-is ({ list, pagination, total_count }) rather than unwrapping to a bare array, sinceFindManyTransactions(unlikeFindManyWallets) carries pagination and a total count that callers need.packages/payments/README.md,docs/INTEGRATION.md, andsdk/AGENTS.md's resource table per the repo's "Docs to keep in sync" section.Linear: AMB-2992
Test plan
pnpm buildpasses (core, then payments)pnpm testpasses — 56/56 tests, including newTransactions.findOne/Transactions.findManytests inpackages/payments/src/resources/transactions.find.test.tspnpm typecheckpassespnpm format:checkpassessdk.tsvia codegen (not hand-edited)