[TM ONLY] Makes phones works across Z-levels and other areas - #156
Open
DiscordWizard wants to merge 3 commits into
Open
[TM ONLY] Makes phones works across Z-levels and other areas#156DiscordWizard wants to merge 3 commits into
DiscordWizard wants to merge 3 commits into
Conversation
dwinters99
requested changes
Aug 28, 2026
| sim_card = new default_sim_card_type(src) | ||
| sim_card.phone_weakref = WEAKREF(src) | ||
| phone_radio = new(src) | ||
| phone_radio = new /obj/item/radio/phone(src) |
There was a problem hiding this comment.
Suggested change
| phone_radio = new /obj/item/radio/phone(src) | |
| phone_radio = new(src) |
unneeded, phone_radio is an implicit type defined by the var, meaning New() doesn't need to be passed a type
Comment on lines
+1
to
+3
| /obj/item/radio/phone/can_receive(input_frequency, list/levels) | ||
| return ..(input_frequency, RADIO_NO_Z_LEVEL_RESTRICTION) // without this, phones only work on their own Z level | ||
|
|
There was a problem hiding this comment.
(NON-BLOCKING) i was going to ask you to modular comment this, but this is a PR that should go upstream after the testing cycle so i'll just mark this as TM only instead for now. me or @FalloutFalcon will upstream it for you if you don't end up getting around to it.
dwinters99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes phones work so if you are in the city and get called from residential or the top of the tower or wherever, you still get the call.
Why It's Good For The Game
Bugfix, and now we can all communicate properly, welcome back anxiety-less communication.
Tested calling on the same Z-level, different areas, atop one another and next to one another, calling works fine.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: phone calling work across z-levels
/:cl: