Repository navigation
Console games from emulators (RPCS3, Dolphin, Cemu) - #82
Merged
Merged
Conversation
- Scan: the PC games never wait for the console search. It runs beside the scan, one at a time with a deadline; results that come later are applied on their own, and console games a search didn't finish looking for stay as they were. Nothing on a network drive or UNC path is opened anywhere in internal/emulated; Cemu-listed games there come from its list alone. Panics in Find are recovered. - Toggling "Add console games from emulators" rescans. - Launch options: the program is only taken from the native picker, the exact command lines are confirmed in a Windows dialog before saving, changing only arguments keeps the program and its folder check (userArgs), and Cancel drops a program picked in the form. ChooseExe clears quit arguments. - Console tracking: only the emulator's folder, only processes started after Play; a boot script that's slow to start the emulator is waited for while it runs (up to 15 min). - Quit arguments run only when the program isn't the game itself. - Ask who plays asks for console games too. - Synced settings carry hideConsoles, so an older Seaglass dropping "emulated" from hidden sources doesn't un-hide consoles.
# Conflicts: # docs/CHANGELOG.md
- A folder walk that stops early now names the game folders it didn't get through (emulated.WalkError); only console games there are kept when not found, so gone games elsewhere are still marked gone. - Launch options refuse quit arguments for the game's own program, which Quit game would never run. - Launch arguments with control or format characters, or broken UTF-8, are refused, so the confirmation shows exactly what runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds console games as a new library next to the PC games. Seaglass finds RPCS3, Dolphin and Cemu and the games their own settings point at, names them from the game or emulator (PARAM.SFO, Dolphin's GameTDB list, Cemu's list), starts them full screen and tracks playtime. PC games aren't touched: console games have their own keys.
Also adds Launch options (arguments, plus optional quit arguments) for any game, so a game can be started through a script or another launcher. Setting to turn it off is in Settings → Library, on by default.
Tested on my PC: 7 games found in about 110 ms, launched Mario Kart Double Dash (Dolphin) and Skylanders Giants (RPCS3) from a dev build, both full screen, session ended and playtime counted when they closed.