Skip to content

CI: regenerate third-party notices instead of failing on a stale copy #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ApolloF merged 1 commit into from
Nov 1, 2026
Merged

CI: regenerate third-party notices instead of failing on a stale copy #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,16 @@ jobs:
working-directory: frontend
run: npm test

- name: Third-party notices up to date
# Fails when a dependency changed without regenerating the file.
run: go run ./tools/notices -check
- name: Third-party notices
# Regenerated so every build ships the notices of the dependencies it
# was built with. A stale committed copy (every Dependabot bump) is a
# warning: run go run ./tools/notices and commit the result.
run: |
go run ./tools/notices
if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE }
if (git status --porcelain -- THIRD_PARTY_NOTICES.txt) {
echo "::warning::THIRD_PARTY_NOTICES.txt is out of date: run go run ./tools/notices and commit the result"
}

- name: Sign
if: env.SIGNPATH != 'true'
Expand Down