Repository navigation
Conversation
build.yml gets a Vet step (go vet ./...) and a Lint step (golangci/golangci-lint-action, golangci-lint pinned to v2.15.0) after the build, since the root package embeds frontend/dist. .golangci.yml enables govet, staticcheck, ineffassign, unused, misspell and gofmt. errcheck and gosec stay off for now: the first run reported 189 and 301 findings, which get their own PRs. The 34 findings of the enabled linters are fixed: De Morgan simplifications, gofmt alignment in test tables, two dead assignments, an unused struct field, Id -> ID in Windows proc names, a nil-map panic in a test marked on purpose, and one doc comment per exported name. Pull requests are never signed (SIGN env): Dependabot's and forks' runs have no secrets, and the job has to pass for them too. SignPath already only ran on tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI now runs
go vet ./...and golangci-lint (pinned v2.15.0, config in.golangci.yml) after the build. Enabled: govet, staticcheck, ineffassign, unused, misspell, gofmt. All 34 findings of those are fixed in this PR (De Morgan rewrites, gofmt alignment, two dead assignments, an unused field,Id->IDin proc names, doc comments).Pull requests are no longer signed at all (
SIGNenv): Dependabot and fork runs have no secrets, so the job must pass unsigned. SignPath was already tags-only. #86/#87/#78 were red only on the old notices step that #88 fixed.The check command in the docs now starts with vet + lint.
Follow-ups, not in this PR:
Close,Remove,Fprintfand syscall.Callreturns.//nolint:gosec // reason.