Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow had
contents: writeat the top, so every PR and Dependabot run got a write token. Now the top level is read-only and onlyrelease(tags) asks for write, which is whatgh release createneeds. Nothing else in the workflow used the token.While I was in there I looked at where the CI time goes: a
buildrun that touches app code takes 26-30 min and 24 of those are the two Robolectric suites, which run one JVM at a time on purpose (side by side they missed their 30 s waits). The only lever left is a second runner for the play suite, that would be a separate PR. The one red smoke run in the last 20 was the Compose timeout #34 fixed.