Repository navigation
Conversation
Standard linters (govet, ineffassign, staticcheck, unused) with all staticcheck checks except ST1005 (error strings are shown to users as sentences) and ST1022 (doc comments may read "Name, when set, ..."). errcheck stays off until its ~50 unchecked Close/Remove calls are fixed. Findings fixed: eight De Morgan simplifications (QF1001), a package comment for internal/app, the ModSpec/HoldNewMod doc comments untangled, two dead helpers in internal/steam removed and a test helper moved to the personal-build test file that uses it.
go vet and golangci-lint v2.15.0 for both builds, then go test -race -short for both builds next to the full test runs. The windows job still needs no secret, so Dependabot PRs keep passing; signing stays in the tag-only release job. CONTRIBUTING.md lists the new tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI only ran the tests and the build, so vet and lint findings and data races slipped through. The windows job now runs go vet, golangci-lint v2.15.0 (.golangci.yml: the standard set, errcheck off for now) and go test -race -short for both builds. The 19 findings of the first run are fixed, no race turned up. Nothing in the job needs a secret, so Dependabot PRs keep passing.
Follow-ups, not in this PR: errcheck (about 50 unchecked Close/Remove calls) and gosec at medium (38 findings, mostly G115 int conversions and G204 exec with a variable).